Skip to content

Lower tanh with the existing unary kernel - #24452

Open
JakeStevens wants to merge 1 commit into
pytorch:mainfrom
JakeStevens:export-D129100402
Open

JakeStevens wants to merge 1 commit into
pytorch:mainfrom
JakeStevens:export-D129100402

Conversation

@JakeStevens

Copy link
Copy Markdown
Contributor

Summary:

Ulterior Motive

Unblock the tanh activation in native MaxViT execution.

Rationale

What: Dispatch aten.tanh.default through the existing unary lowering and ggml_tanh kernel.

Why: The graph builder rejects the operator even though ggml already implements it.

Details

  • Reuse the existing floating-point validation and unary input handling.
  • Check contiguous and transposed inputs with cached and uncached execution.
  • Cover signed zero, infinities, NaN and integer-input rejection.

Authored with AI using Metamate on agentcloud.

Differential Revision: D129100402

Summary:
## Ulterior Motive

Unblock the tanh activation in native MaxViT execution.

## Rationale

**What**: Dispatch `aten.tanh.default` through the existing unary lowering and `ggml_tanh` kernel.

**Why**: The graph builder rejects the operator even though ggml already implements it.

## Details

- Reuse the existing floating-point validation and unary input handling.
- Check contiguous and transposed inputs with cached and uncached execution.
- Cover signed zero, infinities, NaN and integer-input rejection.

Authored with AI using Metamate on agentcloud.

Differential Revision: D129100402
@pytorch-bot

pytorch-bot Bot commented Nov 2, 2026 •

Copy link
Copy Markdown

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/24452

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 New Failures, 2 Unclassified Failures

As of commit 8d4df08 with merge base 822cb60 (image):

NEW FAILURES - The following jobs have failed:

UNCLASSIFIED FAILURES - DrCI could not classify the following jobs because the workflow did not run on the merge base. The failures may be pre-existing on trunk or introduced by this PR:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 2, 2026
@meta-codesync

meta-codesync Bot commented Nov 2, 2026

Copy link
Copy Markdown
Contributor

@JakeStevens has exported this pull request. If you are a Meta employee, you can view the originating Diff in D129100402.

@github-actions

github-actions Bot commented Nov 2, 2026

Copy link
Copy Markdown

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. meta-exported

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant