Repository navigation
Match softmax input storage and layout to its output (#24437) - #24437
Open
JakeStevens wants to merge 1 commit into
Open
JakeStevens wants to merge 1 commit into
JakeStevens wants to merge 1 commit into
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/24437
Note: Links to docs will display an error until the docs builds have been completed. ❌ 9 Pending, 2 Unclassified FailuresAs of commit 20e83ad with merge base cb3f24e ( UNCLASSIFIED FAILURES - DrCI could not classify the following jobs because the workflow did not run on the merge base. The failures may be pre-existing on trunk or introduced by this PR:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
Bot
added
the
CLA Signed
Contributor
|
@JakeStevens has exported this pull request. If you are a Meta employee, you can view the originating Diff in D129088170. |
This PR needs a
|
Summary: ## Ulterior Motive Run native Swin attention softmaxes across buffer and texture storage plans. ## Rationale **What**: Repack the input of `_softmax` and `_log_softmax` when its storage or layout differs from the planned output. **Why**: The kernel reads its input using the output's storage type and texture layout. A buffer bound to a texture shader can crash; a differently packed texture can return misplaced values. ## Details - Adapt only the `self` input of these two operators. - Reuse the existing repack helper and leave matching representations unchanged. - Cover buffer-to-texture and width-to-channels-packed inputs with independent softmax references. Authored with AI using Metamate on agentcloud. Differential Revision: D129088170
meta-codesync
Bot
changed the title
JakeStevens
force-pushed
the
export-D129088170
branch
from
November 2, 2026 20:32
d345309 to
20e83ad
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Ulterior Motive
Run native Swin attention softmaxes across buffer and texture storage plans.
Rationale
What: Repack the input of
_softmaxand_log_softmaxwhen its storage or layout differs from the planned output.Why: The kernel reads its input using the output's storage type and texture layout. A buffer bound to a texture shader can crash; a differently packed texture can return misplaced values.
Details
selfinput of these two operators.Authored with AI using Metamate on agentcloud.
Differential Revision: D129088170