Repository navigation
Prepack stored inputs of clones and clamps (#24436) - #24436
Open
JakeStevens wants to merge 1 commit into
Open
JakeStevens wants to merge 1 commit into
JakeStevens wants to merge 1 commit into
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/24436
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New Failure, 3 Pending, 2 Unclassified FailuresAs of commit 406d2e9 with merge base cb3f24e ( NEW FAILURE - The following job has failed:
UNCLASSIFIED FAILURES - DrCI could not classify the following jobs because the workflow did not run on the merge base. The failures may be pre-existing on trunk or introduced by this PR:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
Bot
added
the
CLA Signed
Contributor
|
@JakeStevens has exported this pull request. If you are a Meta employee, you can view the originating Diff in D129088169. |
This PR needs a
|
Summary: ## Ulterior Motive Unblock Swin V2's stored query/key/value biases and attention logit scales. ## Rationale **What**: Add `aten.clone.default` and `aten.clamp.default` to the existing stored-input prepack list. **Why**: Clone expects a tensor rather than a TensorRef. Clamp also needs a bound input resource; leaving its stored input as a reference can leave the shader descriptor unwritten. ## Details - Reuse the existing explicit prepack path without changing either kernel. - Cover both operators in the prepack pass and numerical engine tests. - Preserve the existing mutation guards and all nonstored-input paths. Authored with AI using Metamate on agentcloud. Differential Revision: D129088169
meta-codesync
Bot
changed the title
JakeStevens
force-pushed
the
export-D129088169
branch
from
November 2, 2026 20:33
9077856 to
406d2e9
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Ulterior Motive
Unblock Swin V2's stored query/key/value biases and attention logit scales.
Rationale
What: Add
aten.clone.defaultandaten.clamp.defaultto the existing stored-input prepack list.Why: Clone expects a tensor rather than a TensorRef. Clamp also needs a bound input resource; leaving its stored input as a reference can leave the shader descriptor unwritten.
Details
Authored with AI using Metamate on agentcloud.
Differential Revision: D129088169