Repository navigation
Return an error from MethodMeta::get_backend_name for a delegate without an id (#24354) - #24354
Merged
Merged
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/24354
Note: Links to docs will display an error until the docs builds have been completed. ⏳ 2 Pending, 1 Unrelated FailureAs of commit 5676a21 with merge base e40e64c ( BROKEN TRUNK - The following job failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
Bot
added
the
CLA Signed
Contributor
|
@sivapatibandla has exported this pull request. If you are a Meta employee, you can view the originating Diff in D128278670. |
meta-codesync
Bot
changed the title
sivapatibandla
added a commit
to sivapatibandla/executorch
that referenced
this pull request
Oct 31, 2026
…out an id (pytorch#24354) Summary: `MethodMeta::get_backend_name` dereferenced the delegate's `id()` without checking it, so a program whose delegate entry has no id crashed instead of returning an error. It now returns `Error::InvalidProgram`, like `Method::init`, which rejects such a delegate with "Missing backend id", while `MethodMeta::uses_backend` already skips it. Reviewed By: metascroy Differential Revision: D128278670
sivapatibandla
force-pushed
the
export-D128278670
branch
from
October 31, 2026 03:32
82ea750 to
fcd460b
Compare
This PR needs a
|
sivapatibandla
added a commit
to sivapatibandla/executorch
that referenced
this pull request
Oct 31, 2026
…out an id (pytorch#24354) Summary: `MethodMeta::get_backend_name` dereferenced the delegate's `id()` without checking it, so a program whose delegate entry has no id crashed instead of returning an error. It now returns `Error::InvalidProgram`, like `Method::init`, which rejects such a delegate with "Missing backend id", while `MethodMeta::uses_backend` already skips it. Reviewed By: metascroy Differential Revision: D128278670
sivapatibandla
force-pushed
the
export-D128278670
branch
2 times, most recently
from
November 2, 2026 18:31
64f1a5e to
b15f936
Compare
sivapatibandla
added a commit
to sivapatibandla/executorch
that referenced
this pull request
Nov 2, 2026
…out an id (pytorch#24354) Summary: `MethodMeta::get_backend_name` dereferenced the delegate's `id()` without checking it, so a program whose delegate entry has no id crashed instead of returning an error. It now returns `Error::InvalidProgram`, like `Method::init`, which rejects such a delegate with "Missing backend id", while `MethodMeta::uses_backend` already skips it. Reviewed By: metascroy Differential Revision: D128278670
metascroy
approved these changes
Nov 2, 2026
…out an id (pytorch#24354) Summary: `MethodMeta::get_backend_name` dereferenced the delegate's `id()` without checking it, so a program whose delegate entry has no id crashed instead of returning an error. It now returns `Error::InvalidProgram`, like `Method::init`, which rejects such a delegate with "Missing backend id", while `MethodMeta::uses_backend` already skips it. Reviewed By: metascroy Differential Revision: D128278670
sivapatibandla
force-pushed
the
export-D128278670
branch
from
November 2, 2026 19:22
b15f936 to
5676a21
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
MethodMeta::get_backend_namedereferenced the delegate'sid()without checking it, so a program whose delegate entry has no id crashed instead of returning an error. It now returnsError::InvalidProgram, likeMethod::init, which rejects such a delegate with "Missing backend id", whileMethodMeta::uses_backendalready skips it.Reviewed By: metascroy
Differential Revision: D128278670