[ROCm] Switch CI to allowlist of validated tests#4248
Open
brucechanglongxu wants to merge 1 commit intopytorch:mainfrom
Open
[ROCm] Switch CI to allowlist of validated tests#4248brucechanglongxu wants to merge 1 commit intopytorch:mainfrom
brucechanglongxu wants to merge 1 commit intopytorch:mainfrom
Conversation
Replace `pytest test` (full suite) with an explicit list of test files that have been validated on MI300X. This avoids running platform-irrelevant tests (x86/ARM quantizers, CUTLASS sparse kernels, CoreML, etc.) that waste CI time and produce noisy failures. The list can be extended as more tests are enabled on ROCm. Addresses pytorch#4219.
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/4248
Note: Links to docs will display an error until the docs builds have been completed. This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
bot
added
the
CLA Signed
jerryzh168
added
topic: rocm
module: not user facing
jerryzh168
reviewed
Apr 7, 2026
| test/test_utils.py \ | ||
| test/test_low_bit_optim.py \ | ||
| test/dtypes/test_nf4.py \ | ||
| test/dtypes/test_affine_quantized.py \ |
Contributor
There was a problem hiding this comment.
we are going to remove affine_quantized tensor soon, probably better to delete this one I think
jerryzh168
approved these changes
Apr 7, 2026
Contributor
jerryzh168
left a comment
jerryzh168
left a comment
There was a problem hiding this comment.
Thanks! would be good to update https://docs.pytorch.org/ao/main/workflows/inference.html#inference-workflows to make sure the configs that support ROCM are all up to date as well in the future
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently the ROCm CI workflow runs
pytest testwhich executes the entire test suite. Most of those tests are irrelevant on ROCm (x86/ARM quantizers, CUTLASS sparse kernels, CoreML codebook tests, etc.) and just add CI time and noise.This switches to an explicit list of test files that have been validated on MI300X across the ROCm enablement PRs. Individual tests within these files that aren't yet supported still skip themselves via
@skip_if_rocm. The list can be extended as we enable more functionality.Addresses #4219.
cc @jerryzh168