[test] Refactor test_quant_api to use shared ToyTwoLinearModel#4236
Open
abhinav-TB wants to merge 2 commits intopytorch:mainfrom
Open
[test] Refactor test_quant_api to use shared ToyTwoLinearModel#4236abhinav-TB wants to merge 2 commits intopytorch:mainfrom
abhinav-TB wants to merge 2 commits intopytorch:mainfrom
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/4236
Note: Links to docs will display an error until the docs builds have been completed. This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
bot
added
the
CLA Signed
jerryzh168
reviewed
Apr 3, 2026
jerryzh168
requested changes
Apr 3, 2026
Author
|
@jerryzh168 , can you review the PR again |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Refactors
test/quantization/test_quant_api.pyto use the shared model architecture fromtorchao.testing.model_architecturesinstead of a local inline toy model.What changed
ToyLinearModeldefinition intest/quantization/test_quant_api.pyToyTwoLinearModelfromtorchao.testing.model_architectures_make_toy_linear_model(...)helper in the test file to preserve existing test ergonomics while mapping:(m, n, k, bias, dtype, device)(input_dim, hidden_dim, output_dim, has_bias, dtype, device)_make_toy_linear_model(...)dtypeanddevicewhere neededWhy
This is an incremental step for #2078 to reduce duplicated toy model definitions and standardize on shared testing architectures, while keeping PR scope small and reviewable.