[RELEASE TEST] Remove unnecessary Torch dependency from ExecuTorch ops build#4199
Draft
manuelcandales wants to merge 1 commit intorelease/0.17.0from
Draft
[RELEASE TEST] Remove unnecessary Torch dependency from ExecuTorch ops build#4199manuelcandales wants to merge 1 commit intorelease/0.17.0from
manuelcandales wants to merge 1 commit intorelease/0.17.0from
Conversation
The ExecuTorch ops target defines TORCHAO_SHARED_KERNELS_BUILD_EXECUTORCH=1, which means shared kernel headers use ExecuTorch includes, not Torch includes. The find_package(Torch) and TORCH_INCLUDE_DIRS were therefore unnecessary and caused CMake configure failures in standalone ExecuTorch builds where PyTorch is not discoverable via find_package.
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/4199
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New Failure, 1 Cancelled JobAs of commit 8384d26 with merge base 02105d4 ( NEW FAILURE - The following job has failed:
CANCELLED JOB - The following job was cancelled. Please retry:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
bot
added
the
CLA Signed
manuelcandales
added
the
module: not user facing
manuelcandales
added
ciflow/binaries/all
ciflow/rocm
ciflow/benchmark
ciflow/tutorials
ciflow/4xh100
ciflow/xpu
|
Warning: Unknown label
Please add the new label to .github/pytorch-probot.yml |
|
Warning: Unknown label
Please add the new label to .github/pytorch-probot.yml |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The ExecuTorch ops target defines TORCHAO_SHARED_KERNELS_BUILD_EXECUTORCH=1, which means shared kernel headers use ExecuTorch includes, not Torch includes. The find_package(Torch) and TORCH_INCLUDE_DIRS were therefore unnecessary and caused CMake configure failures in standalone ExecuTorch builds where PyTorch is not discoverable via find_package.