Repository navigation
Upgrade to Node 26 and pin pnpm 12.17.0 - #4835
Merged
Merged
Conversation
The frontend image build failed: without a packageManager field, corepack resolved the newest pnpm and the download broke. Node 25+ images also ship without corepack, so the Dockerfiles now install a pinned pnpm with npm. - Node 26 in every Dockerfile, workflow and .tool-versions - pnpm 12.17.0 pinned via packageManager and in every Dockerfile - pnpm/action-setup reads the version from packageManager - pnpm 12 records itself in frontend/pnpm-lock.yaml; frozen installs fail without that entry
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
This PR bumps Node to 26.10.0 and pnpm to 12.17.0 across CI workflows, Dockerfiles and
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4835 +/- ##
=======================================
Coverage 92.41% 92.41%
=======================================
Files 360 360
Lines 10920 10920
Branches 946 946
=======================================
Hits 10092 10092
Misses 706 706
Partials 122 122 🚀 New features to boost your workflow:
|
The action runs at the repository root, where there is no package.json, so it cannot find the packageManager field.
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
docker buildof the frontend failed in thedepsstage:package.jsonhad nopackageManagerfield, socorepack enable pnpmresolved the newest pnpm and the download broke. Node 25+ images also ship without corepack, so the same line cannot work onnode:26-alpineat all.Changes
frontend/Dockerfile(node:26-alpine),backend/Dockerfilejs-stage,Dockerfile.node.local, both workflows that pinned 23.9.0,graphql-schema-diff.yml, root andbadge-service.tool-versions.packageManagerinfrontend/package.json,PNPM_VERSIONinfrontend/Dockerfile,npm install -g pnpm@12.17.0inDockerfile.node.localandbackend/Dockerfile(both previously installed an unpinned latest pnpm).pnpm/action-setupno longer passesversion: 9; it readspackageManagerinstead. Passing both with different values makes the action fail.frontend/pnpm-lock.yaml: pnpm 12 records itself underpackageManagerDependencieswhenpackageManageris set. Without this entrypnpm i --frozen-lockfilefails withERR_PNPM_FROZEN_LOCKFILE_WITH_OUTDATED_LOCKFILE.custom_adminhas nopackageManagerfield, so its lockfile is unchanged.Verified
docker build --target depsoffrontend/onnode:26-alpine: pnpm 12.17.0, frozen install, exit 0.backend/custom_adminfrozen install undernode:26+ pnpm 12.17.0: exit 0, lockfile unchanged.>=20.9.0, pnpm 12 requires>=18.Not verified
pnpm run buildstages for frontend and custom_admin. Needs the backend for codegen plus build args. CI on this PR covers lint and codegen.