Distinguish unshared files from sharing API failures.

Author: filiplajszczak

pythonanywhere_core/files.py

@@ -137,17 +137,21 @@ def sharing_get(self, path: str) -> str:
         """Checks sharing status for a `path`.
 
         Returns url with sharing link if file is shared or an empty
-        string otherwise."""
+        string on HTTP 404 (not shared). Raises on other API errors."""
 
         url = f"{self.sharing_endpoint}?path={path}"
 
         result = call_api(url, "GET")
         if result.ok:
             sharing_url_suffix = result.json()["url"]
             return self._make_sharing_url(sharing_url_suffix)
-        else:
+        if result.status_code == 404:
             return ""
 
+        raise PythonAnywhereApiException(
+            f"GET sharing status for {url} failed, got {result}{self._error_msg(result)}"
+        )
+
     def sharing_delete(self, path: str) -> int:
         """Stops sharing file at `path`.
 

tests/test_files.py

@@ -327,6 +327,23 @@ def test_sharing_get_returns_empty_string_when_path_not_shared(
     assert Files().sharing_get(valid_path) == ""
 
 
+@pytest.mark.parametrize("status_code", [400, 403, 429, 500])
+def test_sharing_get_raises_on_errors_other_than_not_found(
+        api_token, api_responses, base_url, home_dir_path, status_code
+):
+    path = f"{home_dir_path}/README.txt"
+    url = urljoin(base_url, f"sharing/?path={path}")
+    api_responses.add(
+        responses.GET, url=url, status=status_code, json={"detail": "request failed"}
+    )
+
+    with pytest.raises(PythonAnywhereApiException) as exc:
+        Files().sharing_get(path)
+
+    assert str(status_code) in str(exc.value)
+    assert "request failed" in str(exc.value)
+
+
 def test_returns_204_on_sucessful_unshare(
         api_token, api_responses, base_url, home_dir_path, username
 ):