Raise on unsuccessful website deletion.

Author: filiplajszczak

pythonanywhere_core/website.py

@@ -110,10 +110,15 @@ def get_ssl_info(self, domain_name) -> dict:
     def delete(self, domain_name: str) -> dict:
         """Deletes website with ``domain_name``.
         :param domain_name: domain name for website to delete
-        :return: empty dictionary"""
+        :return: empty dictionary on HTTP 204
+        :raises PythonAnywhereApiException: if the response is not HTTP 204"""
 
-        call_api(
+        response = call_api(
             f"{self.websites_base_url}{domain_name}/",
             "delete",
         )
+        if response.status_code != 204:
+            raise PythonAnywhereApiException(
+                f"DELETE website via API failed, got {response}:{response.text}"
+            )
         return {}

tests/test_website.py

@@ -154,6 +154,24 @@ def test_deletes_website(api_responses, domain_name, websites_base_url):
     assert Website().delete(domain_name=domain_name) == {}
 
 
+@pytest.mark.parametrize("status_code", [200, 202, 403, 404, 500])
+def test_delete_raises_unless_response_is_204(
+        api_responses, domain_name, websites_base_url, status_code
+):
+    api_responses.add(
+        responses.DELETE,
+        url=f"{websites_base_url}{domain_name}/",
+        status=status_code,
+        body="unexpected response",
+    )
+
+    with pytest.raises(PythonAnywhereApiException) as exc:
+        Website().delete(domain_name=domain_name)
+
+    assert str(status_code) in str(exc.value)
+    assert "unexpected response" in str(exc.value)
+
+
 def test_sets_lets_encrypt_cert(api_responses, domain_name, domains_base_url):
     api_responses.add(
         responses.POST,