Repository navigation
Add comment commands for closing/accepting advisories - #67
Open
StanFromIreland wants to merge 1 commit into
Open
StanFromIreland wants to merge 1 commit into
StanFromIreland wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To start with this feature, let's add
!closeand!acceptcommands. This is a little more convenient than the current summary system, and it also lets us check whether the command issuer is a PSRT member (technically, to keep things simple, I'm just checking theauthor_associationas all organisation members and repository owners are trusted here).Once this is tested, we can tackle the other issues that depend on this, such as adding a command to add/remove collaborators.
And, of course, there isn't any documentation for this yet 🙃. As such, I based the design on the issue/PR comment API and some testing I did.