Conversation
…erflows ins1() checks the item with setitem(self, -1, v) before growing the array, but since pythongh-156865 the 'e', 'f' and 'Zf' setters detect an overflow only when they pack into the array, which that call skips. The array then grew by one item before the real store failed. Pack into a local buffer before the bounds check, so the check call fails too, and copy the result into the array only for a real index.
skirpichev
requested changes
Sep 29, 2026
Comment on lines
+592
to
+594
| if (PyFloat_Pack2(x, buf, PY_LITTLE_ENDIAN) < 0) { | ||
| return -1; | ||
| } |
Member
There was a problem hiding this comment.
You should move this to the if (i >= 0) branch below, ditto for other functions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
append(),insert()andextend()on an'e','f'or'Zf'array grew the array by one item when they raisedOverflowError, because the overflow was detected only after the array had been resized. The setters now pack the value into a local buffer before the bounds check, so it is rejected before the array grows.arrayappend, insert and extend grow the array onOverflowError#158345