gh-148508: Add another common pattern for iOS SSL failures - #150442
Conversation
|
!buildbot iOS |
|
🤖 New build scheduled with the buildbot fleet by @freakboy3742 for commit 5e9b009 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F150442%2Fmerge The command will test the builders whose names match following regular expression: The builders matched are:
|
| re.search( | ||
| r'wrong.version.number|record.layer.failure|http.request', | ||
| str(getattr(err, "reason", "")), | ||
| re.I |
There was a problem hiding this comment.
Nitpick:
| re.I | |
| re.IGNORECASE |
|
Thanks @freakboy3742 for the PR, and @vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14, 3.15. |
|
GH-150697 is a backport of this pull request to the 3.15 branch. |
|
GH-150698 is a backport of this pull request to the 3.14 branch. |
|
GH-150699 is a backport of this pull request to the 3.13 branch. |
|
Merged, thanks for the fix @freakboy3742. |
|
…es to test_ssl (pythonGH-150442) (python#150699) pythongh-148508: Add another common pattern for iOS SSL failures to test_ssl (pythonGH-150442) Match also '[SSL: HTTP_REQUEST] http request (_ssl.c:1143)'. (cherry picked from commit 540b3d0) Co-authored-by: Russell Keith-Magee <russell@keith-magee.com>
…es to test_ssl (pythonGH-150442) (python#150699) pythongh-148508: Add another common pattern for iOS SSL failures to test_ssl (pythonGH-150442) Match also '[SSL: HTTP_REQUEST] http request (_ssl.c:1143)'. (cherry picked from commit 540b3d0) Co-authored-by: Russell Keith-Magee <russell@keith-magee.com>
|
The ARM64 macOS 3.11 builder has failed three times in a row: ======================================================================
FAIL: test_preauth_data_to_tls_server (test.test_ssl.TestPreHandshakeClose.test_preauth_data_to_tls_server)
----------------------------------------------------------------------
Traceback (most recent call last):
File "/Users/buildbot/buildarea/3.11.pablogsal-macos-m1.macos-with-brew/build/Lib/test/test_ssl.py", line 5099, in test_preauth_data_to_tls_server
self.assertIn("before TLS handshake with data", wrap_error.args[1])
AssertionError: 'before TLS handshake with data' not found in '[SSL: HTTP_REQUEST] http request (_ssl.c:1016)'
----------------------------------------------------------------------https://buildbot.python.org/#/builders/1030 This follows upgrades for macOS 26.2->26.6.2 and OpenSSL 3.6.1->3.6.3 on the worker, and the 3.12 builder also failed for its first build after the upgrade: 3.10 is likely affected, but hasn't run since. Not every run fails, but these security branches don't run very often. We've already made the test more robust, and backported it to 3.13. Let's now backport the |
|
Thanks @freakboy3742 for the PR, and @vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10. |
|
Thanks @freakboy3742 for the PR, and @vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11. |
|
Thanks @freakboy3742 for the PR, and @vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12. |
|
Sorry, @freakboy3742 and @vstinner, I could not cleanly backport this to |
|
Sorry, @freakboy3742 and @vstinner, I could not cleanly backport this to |
|
Sorry, @freakboy3742 and @vstinner, I could not cleanly backport this to |
|
GH-158246 is a backport of this pull request to the 3.12 branch. |
|
GH-158247 is a backport of this pull request to the 3.11 branch. |
|
GH-158248 is a backport of this pull request to the 3.10 branch. |
…es to test_ssl (pythonGH-150442) (python#150699) pythongh-148508: Add another common pattern for iOS SSL failures to test_ssl (pythonGH-150442) Match also '[SSL: HTTP_REQUEST] http request (_ssl.c:1143)'. (cherry picked from commit 540b3d0) Co-authored-by: Russell Keith-Magee <russell@keith-magee.com>
…es to test_ssl (pythonGH-150442) (python#150699) pythongh-148508: Add another common pattern for iOS SSL failures to test_ssl (pythonGH-150442) Match also '[SSL: HTTP_REQUEST] http request (_ssl.c:1143)'. (cherry picked from commit 540b3d0) Co-authored-by: Russell Keith-Magee <russell@keith-magee.com>
The
test_ssl.TestPreHandshakeClose.test_preauth_data_to_tls_servertest fails intermittently on the iOS buildbot because an SSL error doesn't raise the expected TLS handshake error.This test already has an escape clause that allows a skip under certain error conditions (raising a ConnectionError, an OSError, or an SSL error with "wrong version number"). #148536 added a pattern for one type of iOS failure; this PR adds a second failure mode that is observed (simplifying the test into a single regex).
It also tweaks the iOS logging regex to strip an additional space; this should aid Bevedere in reporting stack traces when failures occur.