-
-
Notifications
You must be signed in to change notification settings - Fork 34.4k
gh-148192: Fix Generator._make_boundary behavior with CRLF line endings. #148193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,2 @@ | ||
| ``email.generator.Generator._make_boundary`` now correctly finds the | ||
| boundary when using CRLF linesep. | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This description more about the bugfix implementation than the bug. How about "could fail to detect a duplicate boundary string if And, having written that, it occurs to me we could have the same bug if |
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's be verbose and enhance this comment a bit to make things clearer. How about "Generator checks the message content for the string it is about to use as a boundary ('token' in this test) and when it finds it in our attachment appends .0 to make the boundary it uses unique."