Skip to content

gh-134584 : Optimize and eliminate redundant ref-counting for MAKE_FUNCTION in the JIT#144963

Merged
Fidget-Spinner merged 16 commits intopython:mainfrom
Sacul0457:Optimize_MAKE_FUNCTION
Apr 9, 2026
Merged

gh-134584 : Optimize and eliminate redundant ref-counting for MAKE_FUNCTION in the JIT#144963
Fidget-Spinner merged 16 commits intopython:mainfrom
Sacul0457:Optimize_MAKE_FUNCTION

Conversation

@Sacul0457
Copy link
Copy Markdown
Contributor

@Sacul0457 Sacul0457 commented Feb 18, 2026

Thanks to @Fidget-Spinner for guiding!

Adds _MAKE_FUNCTION to optimizer_bytecodes.c and eliminates redundant ref-counting for MAKE_FUNCTION.

@Fidget-Spinner
Copy link
Copy Markdown
Member

MAKE_FUNCTION might not be a common opcode/show up in the JIT. So I doubt we will see speedups from this one, it's still good to add it to the optimizer though so thanks.

Copy link
Copy Markdown
Member

@markshannon markshannon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.
@Sacul0457 can you update this branch so it can be merged?

@Sacul0457
Copy link
Copy Markdown
Contributor Author

I'm can't seem to find the error logs for the CI failure, so I'm not sure what's the cause of the failure and whether it's related to this PR or not

@Fidget-Spinner
Copy link
Copy Markdown
Member

Sometimes the sanitizer CI is a little flaky, so I've triggered a re-run.

@Sacul0457
Copy link
Copy Markdown
Contributor Author

Seems to pass now, thx!

@kumaraditya303
Copy link
Copy Markdown
Contributor

There are new merge conflicts.

@Sacul0457
Copy link
Copy Markdown
Contributor Author

fixed :)

@savannahostrowski
Copy link
Copy Markdown
Member

Looks like this needs another regen, mind resolving @Sacul0457?

@Sacul0457
Copy link
Copy Markdown
Contributor Author

Fixed!

@Fidget-Spinner
Copy link
Copy Markdown
Member

Sorry this needs merging main again. JIT development has been very active these days 🌀

@Sacul0457
Copy link
Copy Markdown
Contributor Author

No worries, it's great to hear how active the JIT development is :)

@Fidget-Spinner Fidget-Spinner merged commit 38d3aef into python:main Apr 9, 2026
77 checks passed
@Sacul0457 Sacul0457 deleted the Optimize_MAKE_FUNCTION branch April 10, 2026 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants