gh-134584 : Optimize and eliminate redundant ref-counting for MAKE_FUNCTION in the JIT#144963
Conversation
|
MAKE_FUNCTION might not be a common opcode/show up in the JIT. So I doubt we will see speedups from this one, it's still good to add it to the optimizer though so thanks. |
markshannon
left a comment
There was a problem hiding this comment.
Looks good.
@Sacul0457 can you update this branch so it can be merged?
|
I'm can't seem to find the error logs for the CI failure, so I'm not sure what's the cause of the failure and whether it's related to this PR or not |
|
Sometimes the sanitizer CI is a little flaky, so I've triggered a re-run. |
|
Seems to pass now, thx! |
|
There are new merge conflicts. |
|
fixed :) |
|
Looks like this needs another regen, mind resolving @Sacul0457? |
|
Fixed! |
|
Sorry this needs merging main again. JIT development has been very active these days 🌀 |
|
No worries, it's great to hear how active the JIT development is :) |
Thanks to @Fidget-Spinner for guiding!
Adds
_MAKE_FUNCTIONtooptimizer_bytecodes.cand eliminates redundant ref-counting forMAKE_FUNCTION.