Skip to content

test_queue times out #115258

Activity

  1. terryjreedy commented on Feb 10, 2024

    @terryjreedy
    Member

    This has blocked CI from passing for a least one PR, #115250 (now rerunning), but not for another, #115253.

  2. changed the title [-]``test_queue`` timed out on Windows free-threading build (x86)[/-] [+]``test_queue`` timed out on Windows free-threading build[/+] on Feb 10, 2024
  3. Eclips4 commented on Feb 10, 2024

    @Eclips4
    MemberAuthor

    This has blocked CI from passing for a least one PR, #115250 (now rerunning), but not for another, #115253.

    Also seems this issue is not specific to x86, another one fail on x64: #115232

  4. Eclips4 commented on Feb 10, 2024

    @Eclips4
    MemberAuthor

    Looks related to #104750

  5. terryjreedy commented on Feb 10, 2024

    @terryjreedy
    Member

    Since our workflow does not allow over-riding CI failure from unrelated test failures, I think test_queue.PyPriorityQueueTest.test_shutdown_all_methods_in_many_threads should be skipped until fixed.

  6. gvanrossum commented on Feb 10, 2024

    @gvanrossum
    Member

    Shall we just revert gh-104750? It seems I merged it prematurely, see #104750 (comment).

  7. added a commit that references this issue on Feb 10, 2024
  8. gvanrossum commented on Feb 10, 2024

    @gvanrossum
    Member

    If you want to just revert the offending PR, gh-115265 is a full revert (it's currently marinating in CI).

    If someone wants to volunteer to create an alternative PR that just disables that test (ideally only when Windows and free-threading are detected) that would be even better.

  9. added 2 commits that reference this issue on Feb 11, 2024
  10. self-assigned this
    on Feb 11, 2024
  11. 15 remaining items

  12. added a commit that references this issue on Feb 12, 2024
  13. Eclips4 commented on Feb 12, 2024

    @Eclips4
    MemberAuthor

    Okay, just disable those two tests for all platforms. (I'm not in a position to do it myself right now.)

    Done in #115361

  14. added a commit that references this issue on Feb 12, 2024
  15. added 2 commits that reference this issue on Feb 14, 2024
  16. vstinner commented on Mar 14, 2024

    @vstinner
    Member

    What's the status? The tests are skipped for 1 month. If nobody knows how to fix it, I would like to suggest to revert the change which introduced the unstable tests.

  17. gvanrossum commented on Mar 14, 2024

    @gvanrossum
    Member

    What's the status? The tests are skipped for 1 month. If nobody knows how to fix it, I would like to suggest to revert the change which introduced the unstable tests.

    Funny you should ask. There is a fix by the original authors (gh-115940), it just requires review and some validation. I don't want to rush things. Could you maybe review that PR?

  18. added a commit that references this issue on Mar 18, 2024
  19. gvanrossum commented on Mar 18, 2024

    @gvanrossum
    Member

    The updated tests have been pushed.

  20. added a commit that references this issue on Mar 20, 2024
  21. added a commit that references this issue on Mar 25, 2024
  22. added a commit that references this issue on Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    testsTests in the Lib/test dirtype-bugAn unexpected behavior, bug, or error

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions