use pypy 3.12 for the home page graphs - #84
Merged
Merged
Conversation
Author
|
Should wait to merge until there are some new results to show... |
Member
|
I think this may have broken something, as the graph no longer renders, but the cache hasn't been deployed yet from what I can tell @mattip |
Author
|
There is a conceptual bug, I am working on a fix. We run two sets of benchmarks: legacy PyPy and pyperformance. The buildbot currently runs pyperformance, uploads the results, then runs legacy, then uploads the results. So there is a window where a revision has partial results (only pyperformance), the scan for the historical plot finds that version, and the renderer has no data to render. The solution is twofold: only render a version with some data, and only upload when all the results are ready. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use pypy3.12 for the homepage top comparison graph, and add it to the bottom history graph as well