Enable immediate garbage collection of connections.

[aaugustin]

While the legacy implementation is in maintenance mode at this point,
the change looked simple and safe enough to update it as well.

Fix #1749.

[Copilot]

Pull request overview

Enables closed connections to be reclaimed immediately without cyclic GC.

Changes:

• Replaces logger backreferences with weak proxies.
• Clears cancelled keepalive task references.
• Adds regression tests and changelog documentation.

Reviewed changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
src/websockets/asyncio/connection.py	Breaks logger and keepalive cycles.
src/websockets/sync/connection.py	Weakens the logger backreference.
src/websockets/trio/connection.py	Weakens the logger backreference.
src/websockets/legacy/protocol.py	Breaks logger and keepalive cycles.
tests/asyncio/test_connection.py	Adds collection coverage and updates keepalive tests.
tests/sync/test_connection.py	Adds collection coverage.
tests/trio/test_connection.py	Adds collection coverage.
tests/legacy/test_protocol.py	Preserves task references for assertions.
docs/project/changelog.rst	Documents immediate collection.

Suppressed comments (1)

tests/asyncio/test_connection.py:1354

• Calling gc.collect() manually still runs cyclic collection even while automatic GC is disabled, so this test passes with the original reference cycle and doesn't verify immediate reference-counted cleanup. Assert the weak reference immediately after deletion instead.

        gc.collect()
        self.assertIsNone(connection_ref(), "still alive after garbage collection")

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.