Skip to content

Adjust SSL certificate-verification error strings for AWS-LC compat #1751

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aaugustin merged 2 commits into from
Aug 23, 2026
+12 −12
Merged

Adjust SSL certificate-verification error strings for AWS-LC compat #1751

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0cd2ef0
Adjust SSL certificate-verification error strings for AWS-LC compat
stewartsmith Aug 22, 2026
8fa19e9
Apply AWS-LC SSL error string fix to trio tests too.
aaugustin Aug 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions tests/asyncio/test_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -554,7 +554,7 @@ async def test_reject_invalid_server_certificate(self):
async with connect(get_uri(server)):
self.fail("did not raise")
self.assertIn(
"certificate verify failed: self signed certificate",
"self signed certificate",
str(raised.exception).replace("-", " "),
)

Expand All @@ -568,7 +568,7 @@ async def test_reject_invalid_server_hostname(self):
):
self.fail("did not raise")
self.assertIn(
"certificate verify failed: Hostname mismatch",
"Hostname mismatch",
str(raised.exception),
)

Expand Down Expand Up @@ -878,7 +878,7 @@ async def test_https_proxy_invalid_proxy_certificate(self):
async with connect("wss://example.com/"):
self.fail("did not raise")
self.assertIn(
"certificate verify failed: unable to get local issuer certificate",
"unable to get local issuer certificate",
str(raised.exception),
)

Expand All @@ -891,7 +891,7 @@ async def test_https_proxy_invalid_server_certificate(self):
async with connect(get_uri(server), proxy_ssl=self.proxy_context):
self.fail("did not raise")
self.assertIn(
"certificate verify failed: self signed certificate",
"self signed certificate",
str(raised.exception).replace("-", " "),
)
self.assertNumFlows(1)
Expand Down
8 changes: 4 additions & 4 deletions tests/sync/test_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -328,7 +328,7 @@ def test_reject_invalid_server_certificate(self):
with connect(get_uri(server)):
self.fail("did not raise")
self.assertIn(
"certificate verify failed: self signed certificate",
"self signed certificate",
str(raised.exception).replace("-", " "),
)

Expand All @@ -342,7 +342,7 @@ def test_reject_invalid_server_hostname(self):
):
self.fail("did not raise")
self.assertIn(
"certificate verify failed: Hostname mismatch",
"Hostname mismatch",
str(raised.exception),
)

Expand Down Expand Up @@ -615,7 +615,7 @@ def test_https_proxy_invalid_proxy_certificate(self):
with connect("wss://example.com/"):
self.fail("did not raise")
self.assertIn(
"certificate verify failed: unable to get local issuer certificate",
"unable to get local issuer certificate",
str(raised.exception),
)
self.assertNumFlows(0)
Expand All @@ -629,7 +629,7 @@ def test_https_proxy_invalid_server_certificate(self):
with connect(get_uri(server), proxy_ssl=self.proxy_context):
self.fail("did not raise")
self.assertIn(
"certificate verify failed: self signed certificate",
"self signed certificate",
str(raised.exception).replace("-", " "),
)
self.assertNumFlows(1)
Expand Down
8 changes: 4 additions & 4 deletions tests/trio/test_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -567,7 +567,7 @@ async def test_reject_invalid_server_certificate(self):
ssl.SSLCertVerificationError,
)
self.assertIn(
"certificate verify failed: self signed certificate",
"self signed certificate",
str(raised.exception.__cause__).replace("-", " "),
)

Expand All @@ -587,7 +587,7 @@ async def test_reject_invalid_server_hostname(self):
ssl.SSLCertVerificationError,
)
self.assertIn(
"certificate verify failed: Hostname mismatch",
"Hostname mismatch",
str(raised.exception.__cause__),
)

Expand Down Expand Up @@ -884,7 +884,7 @@ async def test_https_proxy_invalid_proxy_certificate(self):
self.fail("did not raise")
self.assertIsInstance(raised.exception.__cause__, ssl.SSLCertVerificationError)
self.assertIn(
"certificate verify failed: unable to get local issuer certificate",
"unable to get local issuer certificate",
str(raised.exception.__cause__),
)

Expand All @@ -900,7 +900,7 @@ async def test_https_proxy_invalid_server_certificate(self):
self.fail("did not raise")
self.assertIsInstance(raised.exception.__cause__, ssl.SSLCertVerificationError)
self.assertIn(
"certificate verify failed: self signed certificate",
"self signed certificate",
str(raised.exception.__cause__).replace("-", " "),
)
self.assertNumFlows(1)
Expand Down