Handle fractional twips measures - #1603
Open
rootsec1 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Word can write fractional values into twips-based attributes, which currently causes
ST_TwipsMeasureto raise while reading properties such asSection.right_margin.This keeps the existing exact integer path (including values above 2^53) and uses float conversion plus rounding only when integer parsing fails. Unit-suffixed measurements and integer serialization remain unchanged.
Regression coverage includes fractional twips through both
ST_TwipsMeasureand the public section margin API, exact large integers, unit suffixes, invalid/non-finite inputs, and serialization.Tests:
pytest tests/oxml/test_simpletypes.py tests/test_section.pyFixes #1539