Skip to content

Fix generator being appended instead of a list in scan carry_shapes #2248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fehiepsi merged 1 commit into from
Aug 23, 2026
Merged

Fix generator being appended instead of a list in scan carry_shapes #2248

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions numpyro/contrib/control_flow/scan.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -192,7 +192,7 @@ def body_fn(wrapped_carry, x, prefix=None):
# store shape of new_carry at a global variable
if len(carry_shapes) < (history + 1):
carry_shapes.append(
[jnp.shape(x) for x in jax.tree.flatten(new_carry)[0]] # ty: ignore[invalid-argument-type]
[jnp.shape(x) for x in jax.tree.flatten(new_carry)[0]]
)
# make new_carry have the same shape as carry
# FIXME: is this rigorous?
Expand Down Expand Up @@ -225,7 +225,7 @@ def body_fn(wrapped_carry, x, prefix=None):
# shape so we don't need to record them here
if (i >= history - 1) and (len(carry_shapes) < history + 1):
carry_shapes.append(
jnp.shape(x) for x in jax.tree.flatten(wrapped_carry[-1])[0]
[jnp.shape(x) for x in jax.tree.flatten(wrapped_carry[-1])[0]]
)
else:
# this is the last rolling step
Expand Down
Loading