Repository navigation
Conversation
[u]G by the signed seven-bit comb of #4797 (its table, VG_P384_COMB, an artifact constant) and [v]Q by the four-bit windows, as P-256's verification (#4770), in place of the joint ladder. The internal point doubling only the joint ladder called is gone. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01TKUFHHNk9SreF92JBY2H8M
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of the PPC64LE audit, #4141 (ECDSA verification). This follows #4797, which gave P-384's public keys and signatures the comb, as #4770 did for P-256, #4795 for brainpoolP256r1/P384r1 and #4800 for P-521.
vg_ecdsa_p384_verifyon PPC64LE now computes[u]G + [v]QbyCfg.pointsWithinstead of the joint ladder (Cfg.points,joint):[u]G: PPC64LE P-384: public keys and RFC 6979 signatures by the signed seven-bit comb #4797's signed seven-bit comb. Its table is the artifact constant the key and signature code already use,VG_P384_COMB.[v]Q: ECDH's four-bit windows (Window.Cfg.mul). They readb, in Montgomery's form, fromEM, wherepointsWithwrites it.Proofs
Proof/Ecdsa/Verify/PPC64LE/P384/Verified.leanfollows P-256's (P256Comb.lean,Verified.lean):combPts_okusesTComb.comb_okandWindow.P384.mul_ok. The windows write the same bytes as brainpoolP384r1's (PPC64LE brainpoolP256r1, P384r1 ECDSA: verification's [u]G by the comb #4795), apart fromU's slots and the second table of bits.verify_ppcusesverifyWith_ok, andverify_ctusestaintSymon the table's symbol.verifyHash_verifiedusesHash.verifyHash_verified_cons.combPts_oktakesset_option exponentiation.threshold 512 in, as brainpoolP384r1's does. Without it,2 ^ 384in the bound onuis not evaluated.No TCB, Spec or registration changes.
Generated crate. Only PPC64LE changes: the verification, and the removal of
vg_p384_point_double, an internal function that only the joint ladder called.Testing
cargo test --target powerpc64le-unknown-linux-gnu --release ecdsapasses, including Wycheproof'secdsa_secp384r1_sha384and_sha512p1363 tests.lake build(every module) andEmit.leanpass on this tree, which ismain(e6521157) plus this commit.check_lean_public_imports.pypass.cargo fmt --checkandclippy -D warningspass.Benchmarks
Run 42546707647:
arches=powerpc64,ecdsa_p384_sha384_verify, basee6521157(main).ecdsa_p384_sha384_verify/64ecdsa_p384_sha384_verify/1024ecdsa_p384_sha384_verify/16384🤖 Generated with Claude Code
https://claude.ai/code/session_01TKUFHHNk9SreF92JBY2H8M