Repository navigation
PPC64LE brainpoolP512r1 ECDH: [d]P by three-bit windows - #4779
Merged
Merged
Conversation
brainpoolP512r1's sixteen entries of four-bit windows (192 bytes each) do not fit the working space past the tables of bits, so its windows take three bits, as P-521's do (Window3.lean), with the complete addition and the Jacobian doubling for any a (rcb, dblJa), as brainpoolP384r1's four-bit windows do (WindowA.lean): Impl/Ecdsa/PPC64LE/Window3A.lean. The scalar's 512 bits are 170 windows and two bits above them: a 171st window from R = O would read a bit past the table of bits (the first bit of the table of p - 2's). So R starts at the entry of the top two bits (mul3top), and the 170 windows below them follow. The proof is P-521's on brainpoolP512r1's field and eight-word layout, with the doublings and the addition for any a. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01TKUFHFbSpgWBYWAsEnfUks
Regenerated with the full emitter on #4722. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01TKUFHFbSpgWBYWAsEnfUks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #4141 (the PPC64LE audit, finding 1). Now that #4722 has merged, this restacks #4769 onto
mainand replaces it. The two commits are #4769's, cherry-picked unchanged.vg_ecdh_brainpoolp512r1on PPC64LE computed[d]Pwith the Montgomery ladder. It now uses three-bit windows with the formulas for anya.Why three bits, and why start from the top two bits
R = Owould read bit 512 in its top window. That is one byte past the table of bits, the first entry of the next table (p − 2's bits, whichMulPowOkprovides), which is 1. Instead,Rstarts at the table's entry for the top two bits (top2, then the usual masked scan, thenR = D), and the 170 windows below follow.What changes
Impl/Ecdsa/PPC64LE/Window3A.lean(new):build3,trip,step3andmul3top.a(rcbwithaatAPand3batB3P;dblJa).Window.Cfg.entry,select3andscanEntry.r3plus a constant (plus3 jfor a window's bits).Proof/Ecdsa/PPC64LE/BrainpoolP512r1/Window.lean(new):mul_ok, which provesR = [k]Pfor everyk < 2^512.asteps (InvJ.dblA',Rep.add).top2_okandtop2_eqfor the start, whereRholds[k >>> 510]Q, which is the windows' invariant atj = 170.Impl/Ecdh/BrainpoolP512r1/PPC64LE.lean:exchangeWithwithWindowA.Cfg.mul3top … B3P.Proof/Ecdh/PPC64LE/BrainpoolP512r1/Verified.lean:win_mulPowOk, as P-521's:Z^(p-2)by PPC64LE: inverses by sliding windows of p − 2 and n − 2 #4762's addition chain (chainPow_ok);3bfromFixed(F'.b3p);VerifiedthroughexchangeWith_ok, with constant time checked bytaint_decideon the new literal.No TCB, Spec or Rust change. The only crate change is
ecdh_brainpoolp512r1.rsand its assembly.Testing
main(66a33292, with PPC64LE P-521 ECDH: [d]P by three-bit windows #4722 and PPC64LE Montgomery multiplication of up to four words: [b] and m in registers, rows as two carry chains #4774), the fulllake buildandEmit.leanpass, and the committed crate is the emitter's output.check_lean_public_imports.pypass.Benchmark
Benchmarks run 42529524175, the same windows. It ran before the addition chain and #4774's multiplication reached either side, with
arches=powerpc64,modules=ecdh_brainpoolp512r1, and basebd7184fc(mainwith the ladder):ecdh_brainpoolp512r1/64Generated by Claude Code