Repository navigation
CI: prefer unauthenticated release downloads with auth fallback - #4766
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release downloads now try the public URL first, even when GH_TOKEN is available, with five-second socket timeouts and up to five attempts for transient failures (2, 4, 8, 16 second backoff). If public downloads fail, fall back to the authenticated API with the same retry policy. Tokens remain restricted to the API and are not forwarded on redirects.
The code comment explains that we have seen unauthenticated endpoints fail while authenticated endpoints work, but want to avoid using up our rate limits.
Based on main after #4765 merged (7e2c0ba). Metrics upload already ignores failures on main, so no workflow change is needed.
Validation: all steps from the Static checks job passed, including the full Python unit suite; 13 focused downloader tests also passed. No Lean, Rust, or generated artifact changes.