Skip to content

PPC64LE brainpoolP512r1 ECDH: [d]P by three-bit windows - #4761

Closed
alex wants to merge 4 commits into
mainfrom
claude/ppc64le-brainpool512-ecdh
Closed

alex wants to merge 4 commits into
mainfrom
claude/ppc64le-brainpool512-ecdh

Conversation

@alex

@alex alex commented Nov 8, 2026

Copy link
Copy Markdown
Member

Part of #4141 (the PPC64LE audit, finding 1). Draft, and depends on #4719 and #4722. This PR needs #4722's Window3.lean and #4731's WindowA.lean, and #4722's branch is older than #4731. So the branch is main with #4719's and #4722's commits cherry-picked (9abd52f7, 6f8bc069), then this PR's two commits (6cb33371, d8f8279a). Review only those two. I'll restack onto #4722 once #4722 includes #4731, or onto main once #4722 merges.

vg_ecdh_brainpoolp512r1 on PPC64LE computed [d]P with the Montgomery ladder. It now uses three-bit windows with the formulas for any a.

Why three bits, and why start from the top two bits

  • Four-bit windows don't fit. brainpoolP512r1's coordinates are 8 words, so an entry is 192 bytes. Sixteen entries from the end of the tables of bits (5632) would end at 8704, past the 8192-byte working space. Eight entries end at 7168, as for P-521 (PPC64LE P-521 ECDH: [d]P by three-bit windows #4722).
  • The top window would read past the table of bits. The scalar's 512 bits are 3 · 170 + 2. So PPC64LE P-521 ECDH: [d]P by three-bit windows #4722's loop of 171 windows from R = O would read bit 512 in its top window. That is one byte past the table of bits, the first entry of the next table (p − 2's bits), which is 1. Instead, R starts at the table's entry for the top two bits (top2, then the usual masked scan, then R = D), and the 170 windows below follow.

What changes

No TCB, Spec or Rust change. The only crate change is ecdh_brainpoolp512r1.rs and its assembly.

Testing

  • The full lake build and Emit.lean pass, and the full emitter's output is committed.
  • The Static checks and check_lean_public_imports.py pass.
  • CI runs the PPC64LE Rust tests on POWER: the curve's Wycheproof ECDH vectors.

Benchmark

To follow: a scoped run, arches=powerpc64, modules=ecdh_brainpoolp512r1, against main.


Generated by Claude Code

The windows of P-256's ECDH (Impl/Ecdsa/PPC64LE/Window.lean) on P-384, whose
a is also -3: the proof of Proof/Ecdsa/PPC64LE/P256/Window.lean on P-384's
field and the signature's layout for six-word coordinates (96 windows, the
table of 16 entries of 144 bytes from byte 5248).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01TKUFHH4GefHP3pmPRSL4N4
P-521's sixteen entries of four-bit windows do not fit the working space past
the tables of bits, so its windows take three bits (Impl/Ecdsa/PPC64LE/Window3.lean):
a table of [e]P for e < 8, then for each of the 176 windows three Jacobian
doublings and one complete addition of the entry selected by a constant-time
scan. The proof is P-256's (Proof/Ecdsa/PPC64LE/P256/Window.lean) on P-521's
field and nine-word layout.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01TKUFHH4GefHP3pmPRSL4N4
brainpoolP512r1's sixteen entries of four-bit windows (192 bytes each) do not
fit the working space past the tables of bits, so its windows take three
bits, as P-521's do (Window3.lean), with the complete addition and the
Jacobian doubling for any a (rcb, dblJa), as brainpoolP384r1's four-bit
windows do (WindowA.lean): Impl/Ecdsa/PPC64LE/Window3A.lean.

The scalar's 512 bits are 170 windows and two bits above them: a 171st
window from R = O would read a bit past the table of bits (the first bit of
the table of p - 2's). So R starts at the entry of the top two bits
(mul3top), and the 170 windows below them follow. The proof is P-521's on
brainpoolP512r1's field and eight-word layout, with the doublings and the
addition for any a.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01TKUFHFbSpgWBYWAsEnfUks
Regenerated with the full emitter.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01TKUFHFbSpgWBYWAsEnfUks

alex commented Nov 8, 2026

Copy link
Copy Markdown
Member Author

Replaced by #4763: the same two commits, now stacked on #4722's restacked branch, so its diff has only them.


Generated by Claude Code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants