Repository navigation
x86-64 AES-GCM: no instances for CPUs with VAES or VPCLMULQDQ but not both - #4692
Merged
Merged
Conversation
alex
force-pushed
the
claude/vg-dispatch-by-api
branch
from
November 8, 2026 20:43
c4cdac8 to
abf6ffa
Compare
alex
force-pushed
the
claude/vg-aes-gcm-tiers
branch
from
November 8, 2026 20:43
87d70dd to
2b47209
Compare
|
This pull request has conflicts with Posted by |
… both No CPU has VAES without VPCLMULQDQ, or the reverse: they came together, with Ice Lake and Zen 3. AES-GCM's x86-64 variants paired them anyway (`vaes`, `vpclmul`, `vaesPclmul`, `aesNiVpclmul`), as did its streaming functions, made for every pair of an AES implementation and a GHASH one. Delete those four variants, and emit the streaming functions for the pairs the remaining variants call (`streamPairs`), so that every AES-GCM and AES-GCM-SIV function on x86-64 has an implementation for each of AES-NI with PCLMULQDQ (with and without AVX's loops), AES-NI alone, PCLMULQDQ alone, VAES with VPCLMULQDQ (in 256 or 512 bits) and the baseline, and no other. The CPU-feature configurations and benchmark profiles that only reached those instances go too. Part of #4548. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01TKUFHFjAR7Byf513R4zuFy
alex
force-pushed
the
claude/vg-aes-gcm-tiers
branch
from
November 8, 2026 21:22
2b47209 to
c3505d9
Compare
alex
enabled auto-merge
November 8, 2026 21:27
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #4548. This is stacked on #4685. There are no trust changes.
No CPU has VAES without VPCLMULQDQ, or the reverse: the two arrived together, with Ice Lake and Zen 3.
ci/rust_matrix.tomlalready called these combinations ones "which no chip has without the other".Despite that, x86-64 AES-GCM had four variants that pair them anyway (
vaes,vpclmul,vaesPclmulandaesNiVpclmul). Its streaming functions were also built for every pair of an AES implementation and a GHASH implementation.What changes
Proof/Variants/AesGcm/X86_64.lean.Proof.AesGcm.X86_64.streamPairs), instead of the cross product of theAesCtr32andGhashlists.aes_gcmgroup inci/rust_matrix.toml, and four profiles inbench/gcm_siv_features.py, existed only to reach the deleted instances. They are removed.Every other dispatcher is unchanged. I compared each dispatcher with the base branch's: the only differences are the deleted arms.
Checks
lake buildpasses.Emit.leanpasses.cpu_tests.py lintandalgorithms_table.py --check.check_lean_public_imports.pypasses.cargo clippyandcargo testpass, including theaes_gcmtests under severalVG_CPU_FEATURESsettings.Generated by Claude Code