Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/installer-message.ts
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ export const isEmptyDeveloperSlotMessage = (message: string): boolean =>

export const isDeleteSuccess = (message: string): boolean =>
isRecognizedInstallerMessage(message) &&
(/\b(?:uninstall|delete|remove|deletion)\b.*\bsuccess(?:ful)?\b/i.test(message) ||
(/\b(?:uninstall|delete|remove|deletion)\b.*\b(?:success(?:ful)?|succeeded)\b/i.test(message) ||
isEmptyDeveloperSlotMessage(message));

const isRecognizedInstallerMessage = (message: string): boolean =>
Expand Down
19 changes: 19 additions & 0 deletions test/roku-capture.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -125,6 +125,25 @@ describe("Roku retry helpers", () => {
expect(init.body.get("archive")).toBe("");
});

it("accepts Roku's Delete Succeeded response", async () => {
const fetchMock = vi
.fn<typeof fetch>()
.mockResolvedValueOnce(
new Response("", {
headers: {
"WWW-Authenticate": 'Digest qop="auth", realm="rokudev", nonce="nonce"',
},
status: 401,
}),
)
.mockResolvedValueOnce(new Response('<font color="red">Delete Succeeded.</font>'));
vi.stubGlobal("fetch", fetchMock);

await expect(deleteInstalledChannel({ ...context, password: "pass" })).resolves.toBe(
"Delete Succeeded.",
);
});

it("supports qop-less Digest installer challenges", async () => {
const fetchMock = vi
.fn<typeof fetch>()
Expand Down