Skip to content

fix: handle invalid bookmark storage #260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
saurabhhhcodes wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: handle invalid bookmark storage #260

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 28 additions & 5 deletions app/hooks/useBookmarks.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,13 +6,36 @@ export type Bookmark = {
title: string;
};

const BOOKMARKS_STORAGE_KEY = "openCSE_bookmarks";

function parseSavedBookmarks(saved: string): Bookmark[] {
const parsed = JSON.parse(saved);

if (!Array.isArray(parsed)) {
throw new Error("Saved bookmarks must be an array");
}

return parsed.filter(
(bookmark): bookmark is Bookmark =>
typeof bookmark?.url === "string" && typeof bookmark?.title === "string",
);
}

export function useBookmarks() {
const [bookmarks, setBookmarks] = useState<Bookmark[]>([]);

useEffect(() => {
const saved = localStorage.getItem("openCSE_bookmarks");
if (saved) {
setBookmarks(JSON.parse(saved));
const saved = localStorage.getItem(BOOKMARKS_STORAGE_KEY);
if (!saved) {
return;
}

try {
setBookmarks(parseSavedBookmarks(saved));
} catch (error) {
console.warn("Invalid bookmark data found:", error);
localStorage.removeItem(BOOKMARKS_STORAGE_KEY);
setBookmarks([]);
}
}, []);

Expand All @@ -25,12 +48,12 @@ export function useBookmarks() {
newBookmarks = [...bookmarks, bookmark];
}
setBookmarks(newBookmarks);
localStorage.setItem("openCSE_bookmarks", JSON.stringify(newBookmarks));
localStorage.setItem(BOOKMARKS_STORAGE_KEY, JSON.stringify(newBookmarks));
};

const isBookmarked = (url: string) => {
return bookmarks.some((b) => b.url === url);
};

return { bookmarks, toggleBookmark, isBookmarked };
}
}