Repository navigation
Test the NUFFT adjoint against the scale of its inner products - #169
Merged
Merged
Conversation
The adjoint tests compared <Ax, y> and <x, A^H y> relative to their own value, which random draws can bring near zero: a cu13 Python 3.10 run of v0.0.20 failed by 1.7e-4 relative on an inner product of 0.02. The difference is now held to rel times |Ax| |y|. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01MFB6QKwdnFNa1C1gmpXsLo
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Matteo · project thread
What changed
The four NUFFT adjoint tests in
tests/test_finufft.pyhold|<Ax, y> - <x, Aᴴy>|torel · |Ax| |y|(_assert_adjoint_pair), instead ofrelof the inner product itself.Why
The v0.0.20 release run failed only on
Test bartorch[cu13] on Python 3.10:test_weights_multiply_the_transform_and_their_conjugate_its_adjointgot 0.019863 against 0.019866 ± 2e-6. With random x and y the inner product can sit near zero, so a relative bound on it is a float32 lottery; the norm product is the scale the rounding error actually has. The publish jobs were skipped because of it.Validation
scripts/lint.shclean. Not run locally (no BART build in this session); CI runs the suite.Documentation impact
None.
Generated by Claude Code