[dkliban]

Problem

The nightly test (s3) job started failing on 2026-10-28 (run 40624725849):

test_path_index_integration.py::test_four_processes_share_segment_downloads FAILED
test_path_index_integration.py::test_cache_pressure_releases_idle_mappings FAILED
E   AttributeError: 'S3Storage' object has no attribute 'location'

Only the transitive dependency pytest changed between the last green run and the first red one (9.1.1 → 9.2.0); pulpcore, django and django-storages were identical.

Root cause

pytest 9.2.0 includes pytest#10644: monkeypatch.setattr() now undoes a patch of an attribute that is not in the target instance's own __dict__ with delattr instead of restoring the original value.

test_fresh_namespace_rebuilds_incompatible_profile does monkeypatch.setattr(domain.get_storage(), "location", ...) on the default domain. Domain.get_storage() for default returns Django's process-global default_storage — a LazyObject. location is stored in the wrapped S3Storage.__dict__ (set in __init__), but not in the LazyObject's own __dict__, so pytest 9.2 tears the patch down with delattr, which proxies through and permanently deletes location from the shared S3Storage. Unit tests run sequentially, so the next tests that call artifact.save() raise in S3Storage._normalize_name. The failure is collection-order dependent, which is why only a subset of tests fail.

Fix

Add pulp_maven/tests/unit/conftest.py with an autouse fixture that rebuilds default_storage before (and after) each test, so no test can inherit process-global storage state mutated by another. Resetting at setup is what makes it order-independent: monkeypatch's finalizer runs after an autouse fixture's, so a teardown-only reset would be masked.

Verification

Reproduced and fixed against the real suite with a moto-backed S3 default_storage:

pytest	fix	result
9.2.0	no	2 failed, 15 passed (reproduces CI)
9.2.0	yes	216 passed, 6 skipped, 0 failed
8.4.2	yes	216 passed, 6 skipped, 0 failed (no regression)

Closes #566

🤖 Generated with Claude Code

[dkliban]

Added a second commit with defense-in-depth on the root-cause test itself.

test_fresh_namespace_rebuilds_incompatible_profile was the sole leaker: it mutated location on the shared process-global default_storage via monkeypatch, which pytest 9.2 then failed to restore. It now patches Domain.get_storage to return a relocated read-only view of the storage instead — visible to the domain reloaded inside build_path_index, restored cleanly on teardown, and never corrupting the shared instance.

Verified against the real suite (moto-backed S3 default_storage, pytest 9.2.0):

• With the conftest removed, the hardened test_path_index_integration.py passes on its own (19 passed) — confirming that test was the only leaker.
• Full change together: 236 passed, 6 skipped, 4 subtests passed (the 234 that passed in CI plus the 2 that were failing).

The conftest reset stays as a general safety net so a future test can't reintroduce this class of leak.