Skip to content

.buzz: carry rh/cluster PRs 4,5,6 into gm-rh and cos-rh charters - #1663

Merged
hosted-pulp-bot merged 1 commit into
mainfrom
gm-rh/carry-prs-4-5-6
Nov 3, 2026
Merged

hosted-pulp-bot merged 1 commit into
mainfrom
gm-rh/carry-prs-4-5-6

Conversation

@hosted-pulp-bot

@hosted-pulp-bot hosted-pulp-bot commented Nov 3, 2026 •

Copy link
Copy Markdown
Collaborator

Carries three merged rh/cluster staging PRs (4, 5, 6) into the live Buzz agent definitions. Buzz-only paths (.buzz/agents/).

  • gm-rh/charter.md: RH separation from every other community (escalation class, #gm 193c165b); two person rule for protected paths; rh/cluster main-protection note.
  • cos-rh/charter.md: citing an approver yes by event id when handing an agent a write; review/merge clause; two person rule. Live Promises section preserved (absent from the render staging tree — render drift flagged to be fixed separately).

goals.md and goal-checks were already in sync, no change.

🤖 Generated with Claude Code

Summary by Sourcery

Carry the RH community separation, protected-path review, and approval-tracking rules into the live GM and CoS Buzz charters.

New Features:

  • Define RH isolation requirements for the GM, including explicit approval for bridges to other communities and escalation handling.
  • Add approver-event citation requirements for actions delegated by the RH CoS.
  • Establish a two-person review and merge process for protected paths in the agents and cluster repositories.

Enhancements:

  • Clarify that protected rh/cluster changes must use pull requests and that the CoS and GM review each other's changes.

Carries the three merged rh/cluster staging PRs into the live agent
definitions (Buzz-only paths):
- gm-rh: RH separation from every other community (escalation class),
  plus the two person rule and rh/cluster main-protection note.
- cos-rh: citing an approver yes by event id when handing an agent a
  write, the review/merge clause, and the two person rule.

Preserves the live cos-rh Promises section (absent from the render tree;
render drift flagged separately). goals.md/goal-checks already in sync.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@sourcery-ai

sourcery-ai Bot commented Nov 3, 2026 •

Copy link
Copy Markdown
Contributor

Reviewer's Guide

Carries rh/cluster staging PRs 4–6 into the live gm-rh and cos-rh Buzz charters by adding RH isolation, approval provenance, protected-path two-person merging, escalation rules, and rh/cluster main-protection guidance; goals and goal checks remain unchanged.

Sequence diagram for protected-path pull request merging

sequenceDiagram
    participant Author
    participant Reviewer
    participant Approver as Brian_or_Brians_Claude
    participant Repo as Protected_repository
    Author->>Repo: Open pull request
    Author->>Reviewer: Request review
    Reviewer->>Reviewer: Read diff and originating thread
    Reviewer->>Reviewer: Check approval event id covers diff
    alt Approval and scope match
        Reviewer->>Repo: Merge pull request
        Reviewer->>Repo: Add Reviewed-by merger and author
    else Escalation path or approval mismatch
        Reviewer->>Approver: Post Needs_Brian_or_Brians_Claude
        Approver->>Repo: Land pull request
    end
Loading

File-Level Changes

Change Details Files
Adds a two-person review and merge policy for protected repository paths, including approval verification, escalation handling, merge-message requirements, and branch-protection safeguards.
  • Requires protected-path changes to land through pull requests reviewed and merged by the other chief.
  • Requires the reviewer to verify that the approver’s yes covers the exact diff and to record Reviewed-by metadata.
  • Escalates changes to approval rules, escalation-listed files, or newly introduced guard logic to Brian or Brian’s Claude.
  • Documents the corresponding rh/cluster main-protection workflow and restrictions.
.buzz/agents/cos-rh/charter.md
.buzz/agents/gm-rh/charter.md
Strengthens RH community isolation and clarifies the approval provenance required when cos-rh delegates writes or external actions.
  • Prohibits RH bridges to other communities without a bridge-specific explicit approval and marks the separation rule as escalation class.
  • Requires cos-rh to cite the exact approver yes event ID and action when delegating work based on that approval.
.buzz/agents/gm-rh/charter.md
.buzz/agents/cos-rh/charter.md

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@hosted-pulp-bot
hosted-pulp-bot merged commit 90f6a09 into main Nov 3, 2026
2 of 5 checks passed
@hosted-pulp-bot
hosted-pulp-bot deleted the gm-rh/carry-prs-4-5-6 branch November 3, 2026 16:53

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!

Sourcery assessment

Needs a human reviewer. These charter rules define who may merge protected changes in the agents and cluster repos, and which changes must be escalated; if that boundary is wrong, it applies to every protected-path PR from the moment the charter is used. Reverting the charter would not undo any changes already merged under it or their effects on the platform.


Sourcery is free for open source - if you like our reviews please consider sharing them ✨

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant