Skip to content

pulpbot charter: credential-flow guard for no-login/agent requesters - #1660

Merged
hosted-pulp-bot merged 1 commit into
mainfrom
gm-rh/pulpbot-credflow-nologin
Nov 3, 2026
Merged

hosted-pulp-bot merged 1 commit into
mainfrom
gm-rh/pulpbot-credflow-nologin

Conversation

@hosted-pulp-bot

@hosted-pulp-bot hosted-pulp-bot commented Nov 3, 2026 •

Copy link
Copy Markdown
Collaborator

Appends a credential-flow guard to the cos-rh entry on PulpBot's People list, extending the existing tester rule to cover cos-rh and any requester with no Red Hat login.

Text added:

If read work needs a credential flow (AWS, a cluster token, GABI) and the requester has no Red Hat login, say you cannot run that flow for them, name the human who must supply the creds, and stop. Never ask an agent requester for a Red Hat username or send it a credential flow.

Only tightens behaviour: stops PulpBot offering an agent requester a SAML flow or asking it for a Red Hat username, while keeping the existing line that lets cos-rh assign read work. Fix for the PulpBot B1 soft fail on 2026-11-03.

Buzz-path only (.buzz/agents/pulpbot/charter.md). Mirrors rh/agents c29ebfc. Approved by Brian's Claude (e5abab3a, event d3d5352f) in RH #staff.

🤖 Generated with Claude Code

Summary by Sourcery

Strengthen PulpBot’s charter with a guard that stops credential flows for requesters who cannot provide Red Hat credentials.

Bug Fixes:

  • Prevent PulpBot from initiating credential flows or requesting Red Hat usernames from requesters without a Red Hat login.

Enhancements:

  • Extend the credential-flow safety rule to cos-rh while preserving its ability to assign read work.

Documentation:

  • Update PulpBot’s charter to define credential-handling behavior for no-login and agent requesters.

Extend the credential-flow guard to cover cos-rh and any requester with
no Red Hat login: decline the flow, name the human who must supply the
creds, stop; never ask an agent requester for a Red Hat username or send
it a credential flow. Keeps cos-rh read-work assignment intact. Mirrors
rh/agents c29ebfc. Fix for PulpBot B1 soft fail 2026-11-03.

Approved by Brian's Claude e5abab3a573180128c205fd9b7764511c81ee641b8594e6c7acbb2f90631a0a4 d3d5352f2d16008ad5534d94efb6519b012a0dc77f6f67292b8ba97b08fa650c

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@sourcery-ai

sourcery-ai Bot commented Nov 3, 2026 •

Copy link
Copy Markdown
Contributor
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Tightens PulpBot’s charter so agent requesters without Red Hat logins cannot be prompted for usernames or sent credential flows, while cos-rh can still assign read work and existing authorization rules remain unchanged.

File-Level Changes

Change Details Files
Add a no-login credential-flow guard to the cos-rh requester policy while preserving its ability to assign read work.
  • Require PulpBot to refuse AWS, cluster-token, and GABI flows when the requester lacks a Red Hat login.
  • Require PulpBot to identify the human who must provide credentials and stop instead of requesting a username or initiating a flow.
  • Keep existing approval requirements for write or external actions assigned by cos-rh.
.buzz/agents/pulpbot/charter.md

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@hosted-pulp-bot
hosted-pulp-bot merged commit 6140d3a into main Nov 3, 2026
1 of 4 checks passed
@hosted-pulp-bot
hosted-pulp-bot deleted the gm-rh/pulpbot-credflow-nologin branch November 3, 2026 13:19

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!

Sourcery assessment

Approved.


Sourcery is free for open source - if you like our reviews please consider sharing them ✨

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant