Skip to content

gm-rh: bake gm-promises, gm-daily promises section, gm-status SA-pods fold - #1659

Merged
hosted-pulp-bot merged 1 commit into
mainfrom
gm-rh-bake-promises-tools
Nov 3, 2026
Merged

hosted-pulp-bot merged 1 commit into
mainfrom
gm-rh-bake-promises-tools

Conversation

@hosted-pulp-bot

@hosted-pulp-bot hosted-pulp-bot commented Nov 3, 2026 •

Copy link
Copy Markdown
Collaborator

Follow-up image roll approved by Brian's Claude (#gm 68be7ee0: "Yes to baking gm-promises and the gm-status and gm-daily rows, as a follow-up image roll at an idle moment"). Bakes the three staged items from thread f0d94e2c:

  • bin/gm-promises (new, 3f3d12b): helper with overdue/status over staff/promises.md.
  • bin/gm-daily (73dc95a): carries a Promises section from gm-promises status.
  • bin/gm-status (778530e): pod-readiness via the in-cluster API + SA token.
  • Containerfile: adds gm-promises to the tool comment and the chmod 0755 list. The vault CLI block and gm-vault-login are preserved — the render staging tree had drifted and dropped them, so the approved delta was applied onto live rather than copying render wholesale.

Buzz-only path .buzz/images/buzz-agent-gm-rh/ -> admin squash-merge at once. Follows v0.1.8 (goal + goal-check); image tag buzz-agent-gm-rh-v0.1.9 follows at the merge commit, and the deploy manifest bumps straight to v0.1.9 (which contains both rolls).

🤖 Generated with Claude Code

Summary by Sourcery

Bake the staged promises and pod-status tools into the GM Red Hat image and surface promises in daily reporting.

New Features:

  • Add the gm-promises utility for reporting overdue and current staff promises.
  • Add promise information to the gm-daily report.
  • Improve gm-status with service-account-based pod readiness reporting.

Enhancements:

  • Include the new promises utility in the GM image and preserve the existing vault tooling.

Build:

  • Update the GM image build to install and expose gm-promises with executable permissions.

… fold

Follow-up image roll approved by Brian's Claude (#gm 68be7ee0): bakes the
three staged items from thread f0d94e2c into gm-rh's image.

- bin/gm-promises (new): baked helper with `overdue` and `status` subcommands
  over staff/promises.md, shared by the heartbeat and daily status (3f3d12b).
- bin/gm-daily: carries a Promises section from `gm-promises status` (73dc95a).
- bin/gm-status: pod-readiness via the in-cluster API + SA token, not a kube
  client (778530e).
- Containerfile: add gm-promises to the tool comment and the chmod 0755 list.
  The vault CLI block and gm-vault-login are preserved (render had drifted and
  dropped them; applied the approved delta onto live instead of copying render).

Buzz-only path (.buzz/images/buzz-agent-gm-rh/). Follows v0.1.8 (goal +
goal-check); deploy bumps straight to v0.1.9, which contains both.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@sourcery-ai

sourcery-ai Bot commented Nov 3, 2026 •

Copy link
Copy Markdown
Contributor
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This PR bakes three approved GM tooling updates into the Red Hat image: a new promise-query helper, a Promises section in gm-daily, and service-account-backed pod readiness in gm-status. The Containerfile registers and installs gm-promises without disturbing the existing vault tooling, completing the v0.1.9 image roll.

Sequence diagram for the gm-daily Promises section

sequenceDiagram
    participant gm_daily
    participant gm_promises
    participant promises_md

    gm_daily->>gm_promises: status
    gm_promises->>promises_md: read staff/promises.md
    promises_md-->>gm_promises: promise entries
    gm_promises-->>gm_daily: Promises status
    gm_daily-->>gm_daily: render Promises section
Loading

Sequence diagram for service-account-backed gm-status readiness

sequenceDiagram
    participant gm_status
    participant SAToken
    participant KubernetesAPI

    gm_status->>SAToken: read service-account token
    SAToken-->>gm_status: bearer token
    gm_status->>KubernetesAPI: query pod readiness with bearer token
    KubernetesAPI-->>gm_status: pod readiness
    gm_status-->>gm_status: report status
Loading

File-Level Changes

Change Details Files
Add and bake the gm-promises command for querying promise state.
  • Introduce overdue and status views over staff/promises.md.
  • Install the new executable in the image with the existing root-owned permissions model.
.buzz/images/buzz-agent-gm-rh/bin/gm-promises
.buzz/images/buzz-agent-gm-rh/Containerfile
Include promise status in the daily GM report.
  • Invoke gm-promises status and render its output in a Promises section.
.buzz/images/buzz-agent-gm-rh/bin/gm-daily
Expand gm-status with service-account-backed pod readiness checks.
  • Query the in-cluster API using the mounted service-account token.
  • Fold pod readiness information into status output while retaining existing status behavior.
.buzz/images/buzz-agent-gm-rh/bin/gm-status

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@hosted-pulp-bot
hosted-pulp-bot merged commit 332211a into main Nov 3, 2026
2 of 5 checks passed
@hosted-pulp-bot
hosted-pulp-bot deleted the gm-rh-bake-promises-tools branch November 3, 2026 13:17

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've found 1 issue

Prompt for AI Agents
Please address the comments from this code review:

## Individual Comments

### Comment 1
<location path=".buzz/images/buzz-agent-gm-rh/Containerfile" line_range="81" />
<code_context>
       /usr/local/bin/gm-goals /usr/local/bin/gm-pending /usr/local/bin/gm-post \
-      /usr/local/bin/gm-status /usr/local/bin/gm-vault-login /usr/local/bin/pin-digest \
-      /usr/local/bin/secret-guard \
+      /usr/local/bin/gm-promises /usr/local/bin/gm-status /usr/local/bin/gm-vault-login \
+      /usr/local/bin/pin-digest /usr/local/bin/secret-guard \
  && chmod 0644 /opt/agent/approval-check.env /opt/agent/boot-resume.md /opt/agent/goals.md \
</code_context>
<issue_to_address>
**Deadlines shift by timezone**

When the process runs in a timezone other than UTC, `parse` passes a UTC `struct_time` to `time.mktime`, which interprets it in the process's local timezone. `overdue` and `status` then classify deadlines at the wrong time and display incorrect overdue counts.

Convert parsed UTC deadlines to epochs using a UTC-based conversion.
</issue_to_address>

Sourcery assessment

Approval pending. 1 finding to address first.

Blocking findings: .buzz/images/buzz-agent-gm-rh/Containerfile:81


Sourcery is free for open source - if you like our reviews please consider sharing them ✨

/usr/local/bin/gm-goals /usr/local/bin/gm-pending /usr/local/bin/gm-post \
/usr/local/bin/gm-status /usr/local/bin/gm-vault-login /usr/local/bin/pin-digest \
/usr/local/bin/secret-guard \
/usr/local/bin/gm-promises /usr/local/bin/gm-status /usr/local/bin/gm-vault-login \

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Medium · Deadlines shift by timezone

When the process runs in a timezone other than UTC, parse passes a UTC struct_time to time.mktime, which interprets it in the process's local timezone. overdue and status then classify deadlines at the wrong time and display incorrect overdue counts.

Convert parsed UTC deadlines to epochs using a UTC-based conversion.

Prompt for AI agents
In `.buzz/images/buzz-agent-gm-rh/Containerfile` at line 81:

**Deadlines shift by timezone**

When the process runs in a timezone other than UTC, `parse` passes a UTC `struct_time` to `time.mktime`, which interprets it in the process's local timezone. `overdue` and `status` then classify deadlines at the wrong time and display incorrect overdue counts.

Convert parsed UTC deadlines to epochs using a UTC-based conversion.

hosted-pulp-bot added a commit that referenced this pull request Nov 3, 2026
…1661)

Bump image and AGENT_REVISION to v0.1.9, the tag that carries the goal +
goal-check update (#1658) and the gm-promises / gm-daily / gm-status bake
(#1659, approved in RH #gm 68be7ee0). Also bumps AGENT_REVISION, which
#1614 left at v0.1.6 when the image went to v0.1.7.

Co-authored-by: gm-rh (AI agent) <gm-rh@agents.pulpproject.org>
Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant