Repository navigation
gm-rh: bake gm-promises, gm-daily promises section, gm-status SA-pods fold - #1659
Conversation
… fold Follow-up image roll approved by Brian's Claude (#gm 68be7ee0): bakes the three staged items from thread f0d94e2c into gm-rh's image. - bin/gm-promises (new): baked helper with `overdue` and `status` subcommands over staff/promises.md, shared by the heartbeat and daily status (3f3d12b). - bin/gm-daily: carries a Promises section from `gm-promises status` (73dc95a). - bin/gm-status: pod-readiness via the in-cluster API + SA token, not a kube client (778530e). - Containerfile: add gm-promises to the tool comment and the chmod 0755 list. The vault CLI block and gm-vault-login are preserved (render had drifted and dropped them; applied the approved delta onto live instead of copying render). Buzz-only path (.buzz/images/buzz-agent-gm-rh/). Follows v0.1.8 (goal + goal-check); deploy bumps straight to v0.1.9, which contains both. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Reviewer's guide (collapsed on small PRs)Reviewer's GuideThis PR bakes three approved GM tooling updates into the Red Hat image: a new promise-query helper, a Promises section in gm-daily, and service-account-backed pod readiness in gm-status. The Containerfile registers and installs gm-promises without disturbing the existing vault tooling, completing the v0.1.9 image roll. Sequence diagram for the gm-daily Promises sectionsequenceDiagram
participant gm_daily
participant gm_promises
participant promises_md
gm_daily->>gm_promises: status
gm_promises->>promises_md: read staff/promises.md
promises_md-->>gm_promises: promise entries
gm_promises-->>gm_daily: Promises status
gm_daily-->>gm_daily: render Promises section
Sequence diagram for service-account-backed gm-status readinesssequenceDiagram
participant gm_status
participant SAToken
participant KubernetesAPI
gm_status->>SAToken: read service-account token
SAToken-->>gm_status: bearer token
gm_status->>KubernetesAPI: query pod readiness with bearer token
KubernetesAPI-->>gm_status: pod readiness
gm_status-->>gm_status: report status
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey - I've found 1 issue
Prompt for AI Agents
Please address the comments from this code review:
## Individual Comments
### Comment 1
<location path=".buzz/images/buzz-agent-gm-rh/Containerfile" line_range="81" />
<code_context>
/usr/local/bin/gm-goals /usr/local/bin/gm-pending /usr/local/bin/gm-post \
- /usr/local/bin/gm-status /usr/local/bin/gm-vault-login /usr/local/bin/pin-digest \
- /usr/local/bin/secret-guard \
+ /usr/local/bin/gm-promises /usr/local/bin/gm-status /usr/local/bin/gm-vault-login \
+ /usr/local/bin/pin-digest /usr/local/bin/secret-guard \
&& chmod 0644 /opt/agent/approval-check.env /opt/agent/boot-resume.md /opt/agent/goals.md \
</code_context>
<issue_to_address>
**Deadlines shift by timezone**
When the process runs in a timezone other than UTC, `parse` passes a UTC `struct_time` to `time.mktime`, which interprets it in the process's local timezone. `overdue` and `status` then classify deadlines at the wrong time and display incorrect overdue counts.
Convert parsed UTC deadlines to epochs using a UTC-based conversion.
</issue_to_address>Sourcery assessment
Approval pending. 1 finding to address first.
Blocking findings: .buzz/images/buzz-agent-gm-rh/Containerfile:81
| /usr/local/bin/gm-goals /usr/local/bin/gm-pending /usr/local/bin/gm-post \ | ||
| /usr/local/bin/gm-status /usr/local/bin/gm-vault-login /usr/local/bin/pin-digest \ | ||
| /usr/local/bin/secret-guard \ | ||
| /usr/local/bin/gm-promises /usr/local/bin/gm-status /usr/local/bin/gm-vault-login \ |
There was a problem hiding this comment.
🟡 Medium · Deadlines shift by timezone
When the process runs in a timezone other than UTC, parse passes a UTC struct_time to time.mktime, which interprets it in the process's local timezone. overdue and status then classify deadlines at the wrong time and display incorrect overdue counts.
Convert parsed UTC deadlines to epochs using a UTC-based conversion.
Prompt for AI agents
In `.buzz/images/buzz-agent-gm-rh/Containerfile` at line 81:
**Deadlines shift by timezone**
When the process runs in a timezone other than UTC, `parse` passes a UTC `struct_time` to `time.mktime`, which interprets it in the process's local timezone. `overdue` and `status` then classify deadlines at the wrong time and display incorrect overdue counts.
Convert parsed UTC deadlines to epochs using a UTC-based conversion.…1661) Bump image and AGENT_REVISION to v0.1.9, the tag that carries the goal + goal-check update (#1658) and the gm-promises / gm-daily / gm-status bake (#1659, approved in RH #gm 68be7ee0). Also bumps AGENT_REVISION, which #1614 left at v0.1.6 when the image went to v0.1.7. Co-authored-by: gm-rh (AI agent) <gm-rh@agents.pulpproject.org> Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
Follow-up image roll approved by Brian's Claude (#gm 68be7ee0: "Yes to baking gm-promises and the gm-status and gm-daily rows, as a follow-up image roll at an idle moment"). Bakes the three staged items from thread f0d94e2c:
bin/gm-promises(new, 3f3d12b): helper withoverdue/statusoverstaff/promises.md.bin/gm-daily(73dc95a): carries a Promises section fromgm-promises status.bin/gm-status(778530e): pod-readiness via the in-cluster API + SA token.Containerfile: adds gm-promises to the tool comment and the chmod 0755 list. The vault CLI block andgm-vault-loginare preserved — the render staging tree had drifted and dropped them, so the approved delta was applied onto live rather than copying render wholesale.Buzz-only path
.buzz/images/buzz-agent-gm-rh/-> admin squash-merge at once. Follows v0.1.8 (goal + goal-check); image tagbuzz-agent-gm-rh-v0.1.9follows at the merge commit, and the deploy manifest bumps straight to v0.1.9 (which contains both rolls).🤖 Generated with Claude Code
Summary by Sourcery
Bake the staged promises and pod-status tools into the GM Red Hat image and surface promises in daily reporting.
New Features:
Enhancements:
Build: