Add fine-grained pipeline cut-points for INSIDE config#23
Open
gamzeisl wants to merge 7 commits into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR refines the INSIDE pipeline configuration to support multiple, unit-specific cut-points, allowing NumPipeRegs to be distributed across more optimal datapath boundaries (reducing reliance on synthesis retiming). It also updates the recommended Snitch pipeline preset and documentation to reflect the new behavior.
Changes:
- Introduces finer-grained internal pipeline stage allocation for
INSIDEacross several units (FMA, casts, non-comp, dotp variants). - Refactors MXDOTP normalization into multiple sub-stages/modules to enable additional cut-points.
- Adds
DEFAULT_SNITCH_PIPEinfpnew_pkg.svand updates docs to describe the new placement strategy and include a distribution figure.
Reviewed changes
Copilot reviewed 8 out of 9 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/mxdotp/fpnew_mxdotp_multi_modules.sv | Refactors MXDOTP helper modules and splits normalization to support additional internal cut-points. |
| src/fpnew_mxdotp_multi.sv | Updates MXDOTP top-level pipeline segmentation and reconnects to new normalization stages. |
| src/fpnew_sdotp_multi.sv | Adds multiple internal cut-points and new internal pipeline segments for SDOTP. |
| src/fpnew_fma_multi.sv | Adds multiple internal cut-points and re-stages FMA datapath around them. |
| src/fpnew_cast_multi.sv | Adds internal cut-point pipelines around normalization/rounding and retimes control/data. |
| src/fpnew_noncomp.sv | Adds an internal mid-pipeline stage for INSIDE and updates handshake/busy tracking. |
| src/fpnew_pkg.sv | Introduces DEFAULT_SNITCH_PIPE preset for recommended INSIDE register counts. |
| docs/README.md | Updates documentation for PipeConfig behavior and adds a distribution figure reference. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Angelo Nujic <anujic@student.ethz.ch>
Co-authored-by: Angelo Nujic <anujic@student.ethz.ch>
Co-authored-by: Angelo Nujic <anujic@student.ethz.ch>
Co-authored-by: Angelo Nujic <anujic@student.ethz.ch>
Co-authored-by: Angelo Nujic <anujic@student.ethz.ch>
Co-authored-by: Angelo Nujic <anujic@student.ethz.ch>
Co-authored-by: Angelo Nujic <anujic@student.ethz.ch>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, the
INSIDEpipe configuration placed allNumPipeRegsregisters at a single mid-point inside each unit, requiring retiming.This PR introduces multiple cut-points located at roughly ideal boundaries in each unit's datapath, allowing
NumPipeRegsregisters to be distributed where they most effectively break critical paths.Units updated:
fpnew_noncomp,fpnew_cast_multi,fpnew_fma_multi,fpnew_mxdotp_multi,fpnew_sdotp_multi.The updated
DEFAULT_SNITCH_PIPElocalparam infpnew_pkg.svreflects the recommended register counts for the Snitch configuration.