Repository navigation
Add signed BTC provider-v2 for Locks payment-only policies - #127
Merged
Merged
Conversation
ben-kaufman
reviewed
Nov 4, 2026
ben-kaufman
reviewed
Nov 4, 2026
ben-kaufman
approved these changes
Nov 5, 2026
ben-kaufman
left a comment
Contributor
There was a problem hiding this comment.
The expiry and payment-drain issues are fixed. Looks good.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds signed BTC-only provider-v2 APIs for Locks payment-only policies:
POST /v2/invoicesandPOST /v2/invoices/status0024_provider_v2_contract.sqlThis is additive. Existing v1 behavior remains unchanged. No dependency, generated-binding, or version changes are included.
Independent exact-SHA review
Internal independent review task
t_9179f94capproved unchanged commitd98f3e93fa02281d6df0c888250f8abd002d9d1a(tree05a6b7503281bb129dce36beb7a298ce4b29e3ee). Contract attachment SHA-256:8cd97bbe1b8cce8d6f2c35b7653e01b04b2ca551d9d8bef3daa6dfeb1f5c36d6.Review verification:
paykit-server-e2e: 240 passed, 0 failed; 3 pre-existing live-adapter tests ignored and not executedcargo test --locked -p paykit-server -- --test-threads=1: 486 passed, 0 failed, 0 ignoredcargo fmt --all -- --check: passedcargo clippy --locked --workspace --all-targets -- -D warnings: passedcargo doc --locked --workspace --no-deps: passedgit diff --check, andgit show --checkgates: passedReview caveats
README.mdis a known merge hotspot against newer master.server.rsandpersistence/invoices.rsoverlap open PR feat: allowance intake in production #122; this PR does not absorb PR feat: allowance intake in production #122's USDT/allowance work.Rollout boundaries
No production migration, deployment, release, tag, or external-adapter operation is performed by this PR. Migration 0024 is published unchanged and must be applied through human-controlled deployment. Locks payment-only integration remains blocked on human merge of this provider PR, immutable provider release, and human merge of Graph Stage 1 PR #120.