Repository navigation
fix(typescript): load best practices with a glob rule - #73
Merged
Merged
Conversation
Antigravity skills have no paths field, and typescript-best-practices sets disable-model-invocation. A plugin rule with trigger glob on TypeScript files routes the agent to that skill. Co-authored-by: Kaitian Xie <caelaxie@users.noreply.github.com>
caelaxie
commented
Nov 17, 2026
caelaxie
left a comment
Collaborator
Author
There was a problem hiding this comment.
pass. adds rules/typescript-best-practices.md exactly as #67 asked: trigger: glob, globs: "**/*.ts, **/*.tsx", body routes to skills/typescript-best-practices/SKILL.md, and paths is not put back on the skill. head 0ee4282. agy 1.5.9 install+list on that sha plus Validate plugin CI both show rules 1 (typescript-best-practices) and the three embedded skills (deslop, control-cli, control-ui). Closes #67. squash-merging.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
summary
typescript-best-practicescorrectly has nopathsfield. Antigravity skill frontmatter does not supportpaths, and the skill setsdisable-model-invocation: true, so its description does not load it on its own.This adds
rules/typescript-best-practices.mdat the plugin root, next toskills/, withtrigger: globandglobs: "**/*.ts, **/*.tsx"(a comma-separated string). The body routes the agent toskills/typescript-best-practices/SKILL.md.pathsis not put back on the skill.#1249deletesskills/reflect/references/synthesizer.mdon the port branch. That file's note in the issue does not apply here. This PR is from main and does not touch that file.Closes #67
harness proof
Head
0ee4282f7edca326a44333c64aaec1889bec3d9f.agy1.5.9. Commands ran on this commit.agy plugin validate --strictreportsrules 1, and install loadstypescript-best-practices. A liveagy --printturn needs a Google login this environment does not have. Poteto-mode scripts: 62 pass, 0 fail. Statechart: 340 tests, 270 pass, 0 fail, 70 skipped.