Builder Api#28
Open
dbcfd wants to merge 2 commits into
Open
Conversation
rossmacarthur
left a comment
rossmacarthur
left a comment
There was a problem hiding this comment.
Thanks, I made, some small comments, I will test out this branch as well :)
Introduce a builder api that better supports creating pending and activated handles, and creating streams from those handles. Config now supports defining which handle type (dead, live, file). Additional support for configuring handles with linktype and rfmon.
dbcfd
force-pushed
the
24-builder-api
branch
from
63237d8 to
0daa01c
Compare
Collaborator
Author
Made changes per review, and added rfmon support. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Provide a builder style api for creating pending handles, then activating them.
Config now supports specifying interface to simplify creation, and a stream can
be created from a config without needing to first create a handle.