fix(a11y/seo): downgrade FeedbackButton dialog titles from h1 to h2#50
Open
forgetso wants to merge 1 commit into
Open
fix(a11y/seo): downgrade FeedbackButton dialog titles from h1 to h2#50forgetso wants to merge 1 commit into
forgetso wants to merge 1 commit into
Conversation
The feedback modal is hidden by default but still lives in the DOM on every
docs page, so crawlers were seeing two extra h1 elements ("What's on your
mind?" and "Send us feedback") alongside the real page h1, tripping duplicate
H1 audit warnings across the entire site (including every localised copy).
Both dialog titles become h2s with a shared .dialog-title class; the scoped
selector is renamed to match, preserving the existing styling. Nested
.select-buttons h2 rules are unaffected.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
✅ Deploy Preview for peaceful-pothos-9e62ce ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
<h1>elements (feedback.formTitleandfeedback.sendFeedback) alongside the real page<h1>.<h2 class="dialog-title">; the scopedh1 { … }selector is renamed to.dialog-title { … }so the styling is preserved without depending on the tag name..select-buttons h2rules are unaffected.Test plan
<h1>remains (the Starlight page title).🤖 Generated with Claude Code