Repository navigation
Conversation
web only used Secret and JoinDir from that package, but importing it links everything the HTTP client configuration needs, so every exporter using web inherited client_golang, oauth2, jwt, protobuf and more. Bump prometheus/common to the merge commit of prometheus/common#1024, which moved Secret into config/secret, and use that package. Inline JoinDir, the only other use. config.Secret is an alias of secret.Secret, so the exported fields stay compatible. The modules linked by web go from 25 to 10. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Manuel Rüger <manuel@rueg.eu>
SuperQ
reviewed
Nov 12, 2026
| github.com/mdlayher/vsock v1.3.0 | ||
| github.com/prometheus/client_golang v1.23.2 | ||
| github.com/prometheus/common v0.73.0 | ||
| github.com/prometheus/common v0.73.2-0.20261110090952-e8b548eaa013 |
Contributor
Author
There was a problem hiding this comment.
Will look into this tomorrow
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
webonly used two things fromgithub.com/prometheus/common/config:SecretandJoinDir. Importing that package links everything the HTTP client configuration needs, so every exporter usingwebinherited client_golang, oauth2, jwt, protobuf and more.prometheus/common#1024 moved
Secretintoconfig/secret, which has no third-party dependencies. This PR:secret.SecretinwebJoinDiras an unexported helper, sowebno longer importsconfigat allconfig.Secretis an alias ofsecret.Secret, so the exportedUsersandTLSKeyfields stay assignable fromconfig.Secretand this is not an API change for callers.config.MarshalSecretValuestill works for programs that linkconfig.Effect on dependencies
Third-party modules and packages linked by each package, not counting exporter-toolkit itself:
webweb/kingpinflagbootstrapAcross the module,
go.modgoes from 19 indirect requirements to 12, andgo.sumfrom 82 lines to 68.Removed from
webandweb/kingpinflag:Removed from
bootstrap, which still needs client_golang for its metrics handler:Dropped from
go.modentirely: jwt, google/uuid, hashicorp/go-uuid, backoff, go-conntrack, x/oauth2 and x/text. The bump also raises go-abnf to v0.5.5 and x/net to v0.62.0, the minimum versions the new prometheus/common requires.To reproduce, run this on
masterand on this branch:🤖 Generated with Claude Code