Skip to content

WIP: optimize sample unmarshaling for json/v2 #991

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
liggitt wants to merge 7 commits into
base: main
Choose a base branch
from
Open

WIP: optimize sample unmarshaling for json/v2 #991

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
07f488c
Add json v1/v2, round-trip, and sample unmarshal benchmark tests
liggitt Sep 17, 2026
e73ffef
TMP: benchmark 1
liggitt Sep 19, 2026
a39ac7b
Drop unnecessary custom UnmarshalJSON
liggitt Sep 17, 2026
94281fd
TMP: benchmark 2
liggitt Sep 19, 2026
28e8398
SamplePair#UnmarshalJSONFrom
liggitt Sep 17, 2026
0d86d7a
histogram UnmarshalJSONFrom implementations
liggitt Sep 17, 2026
68760d9
TMP: benchmark 3
liggitt Sep 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
114 changes: 114 additions & 0 deletions 1-go1.26
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,114 @@
goos: darwin
goarch: arm64
pkg: github.com/prometheus/common/model
cpu: Apple M4 Pro
BenchmarkSamplesJSONUnmarshal/series=10/dp=10/type=floats-14 19749 59746 ns/op 31912 B/op 530 allocs/op
BenchmarkSamplesJSONUnmarshal/series=10/dp=10/type=floats-14 20172 59221 ns/op 31912 B/op 530 allocs/op
BenchmarkSamplesJSONUnmarshal/series=10/dp=10/type=floats-14 20452 58801 ns/op 31912 B/op 530 allocs/op
BenchmarkSamplesJSONUnmarshal/series=10/dp=10/type=floats-14 20366 59046 ns/op 31912 B/op 530 allocs/op
BenchmarkSamplesJSONUnmarshal/series=10/dp=10/type=floats-14 19682 60888 ns/op 31912 B/op 530 allocs/op
BenchmarkSamplesJSONUnmarshal/series=10/dp=10/type=floats-14 20320 58908 ns/op 31912 B/op 530 allocs/op
BenchmarkSamplesJSONUnmarshal/series=10/dp=10/type=histograms-14 1576 766216 ns/op 226216 B/op 4541 allocs/op
BenchmarkSamplesJSONUnmarshal/series=10/dp=10/type=histograms-14 1569 758976 ns/op 226217 B/op 4541 allocs/op
BenchmarkSamplesJSONUnmarshal/series=10/dp=10/type=histograms-14 1576 762003 ns/op 226217 B/op 4541 allocs/op
BenchmarkSamplesJSONUnmarshal/series=10/dp=10/type=histograms-14 1581 761813 ns/op 226217 B/op 4541 allocs/op
BenchmarkSamplesJSONUnmarshal/series=10/dp=10/type=histograms-14 1610 749092 ns/op 226217 B/op 4541 allocs/op
BenchmarkSamplesJSONUnmarshal/series=10/dp=10/type=histograms-14 1593 757349 ns/op 226217 B/op 4541 allocs/op
BenchmarkSamplesJSONUnmarshal/series=10/dp=100/type=floats-14 2487 477704 ns/op 233352 B/op 3260 allocs/op
BenchmarkSamplesJSONUnmarshal/series=10/dp=100/type=floats-14 2559 474301 ns/op 233353 B/op 3260 allocs/op
BenchmarkSamplesJSONUnmarshal/series=10/dp=100/type=floats-14 2522 474060 ns/op 233353 B/op 3260 allocs/op
BenchmarkSamplesJSONUnmarshal/series=10/dp=100/type=floats-14 2568 473804 ns/op 233353 B/op 3260 allocs/op
BenchmarkSamplesJSONUnmarshal/series=10/dp=100/type=floats-14 2137 497328 ns/op 233355 B/op 3260 allocs/op
BenchmarkSamplesJSONUnmarshal/series=10/dp=100/type=floats-14 2433 495136 ns/op 233353 B/op 3260 allocs/op
BenchmarkSamplesJSONUnmarshal/series=10/dp=100/type=histograms-14 158 7558239 ns/op 2173909 B/op 43271 allocs/op
BenchmarkSamplesJSONUnmarshal/series=10/dp=100/type=histograms-14 159 7466225 ns/op 2173902 B/op 43271 allocs/op
BenchmarkSamplesJSONUnmarshal/series=10/dp=100/type=histograms-14 160 7446880 ns/op 2173908 B/op 43271 allocs/op
BenchmarkSamplesJSONUnmarshal/series=10/dp=100/type=histograms-14 160 7444002 ns/op 2173906 B/op 43271 allocs/op
BenchmarkSamplesJSONUnmarshal/series=10/dp=100/type=histograms-14 160 7451757 ns/op 2173904 B/op 43271 allocs/op
BenchmarkSamplesJSONUnmarshal/series=10/dp=100/type=histograms-14 160 7437477 ns/op 2173909 B/op 43271 allocs/op
BenchmarkSamplesJSONUnmarshal/series=10/dp=1000/type=floats-14 255 4675196 ns/op 2352718 B/op 30300 allocs/op
BenchmarkSamplesJSONUnmarshal/series=10/dp=1000/type=floats-14 258 4687507 ns/op 2352720 B/op 30300 allocs/op
BenchmarkSamplesJSONUnmarshal/series=10/dp=1000/type=floats-14 250 4745232 ns/op 2352719 B/op 30300 allocs/op
BenchmarkSamplesJSONUnmarshal/series=10/dp=1000/type=floats-14 253 4708189 ns/op 2352718 B/op 30300 allocs/op
BenchmarkSamplesJSONUnmarshal/series=10/dp=1000/type=floats-14 255 4685555 ns/op 2352720 B/op 30300 allocs/op
BenchmarkSamplesJSONUnmarshal/series=10/dp=1000/type=floats-14 255 4759820 ns/op 2352721 B/op 30300 allocs/op
BenchmarkSamplesJSONUnmarshal/series=10/dp=1000/type=histograms-14 13 78732638 ns/op 21561970 B/op 430302 allocs/op
BenchmarkSamplesJSONUnmarshal/series=10/dp=1000/type=histograms-14 14 77174158 ns/op 21561142 B/op 430301 allocs/op
BenchmarkSamplesJSONUnmarshal/series=10/dp=1000/type=histograms-14 15 76752169 ns/op 21561134 B/op 430301 allocs/op
BenchmarkSamplesJSONUnmarshal/series=10/dp=1000/type=histograms-14 15 76818981 ns/op 21561155 B/op 430301 allocs/op
BenchmarkSamplesJSONUnmarshal/series=10/dp=1000/type=histograms-14 15 76459964 ns/op 21561156 B/op 430301 allocs/op
BenchmarkSamplesJSONUnmarshal/series=10/dp=1000/type=histograms-14 15 76494561 ns/op 21561125 B/op 430301 allocs/op
BenchmarkSamplesJSONUnmarshal/series=100/dp=10/type=floats-14 2048 591352 ns/op 316793 B/op 5213 allocs/op
BenchmarkSamplesJSONUnmarshal/series=100/dp=10/type=floats-14 2041 585970 ns/op 316793 B/op 5213 allocs/op
BenchmarkSamplesJSONUnmarshal/series=100/dp=10/type=floats-14 2042 585825 ns/op 316793 B/op 5213 allocs/op
BenchmarkSamplesJSONUnmarshal/series=100/dp=10/type=floats-14 2067 599861 ns/op 316793 B/op 5213 allocs/op
BenchmarkSamplesJSONUnmarshal/series=100/dp=10/type=floats-14 2011 586266 ns/op 316793 B/op 5213 allocs/op
BenchmarkSamplesJSONUnmarshal/series=100/dp=10/type=floats-14 2052 585336 ns/op 316793 B/op 5213 allocs/op
BenchmarkSamplesJSONUnmarshal/series=100/dp=10/type=histograms-14 157 7609969 ns/op 2259265 B/op 45314 allocs/op
BenchmarkSamplesJSONUnmarshal/series=100/dp=10/type=histograms-14 158 7567477 ns/op 2259268 B/op 45314 allocs/op
BenchmarkSamplesJSONUnmarshal/series=100/dp=10/type=histograms-14 158 7522933 ns/op 2259265 B/op 45314 allocs/op
BenchmarkSamplesJSONUnmarshal/series=100/dp=10/type=histograms-14 158 7542101 ns/op 2259266 B/op 45314 allocs/op
BenchmarkSamplesJSONUnmarshal/series=100/dp=10/type=histograms-14 158 7556864 ns/op 2259266 B/op 45314 allocs/op
BenchmarkSamplesJSONUnmarshal/series=100/dp=10/type=histograms-14 158 7542475 ns/op 2259266 B/op 45314 allocs/op
BenchmarkSamplesJSONUnmarshal/series=100/dp=100/type=floats-14 250 4730798 ns/op 2331198 B/op 32513 allocs/op
BenchmarkSamplesJSONUnmarshal/series=100/dp=100/type=floats-14 253 4702618 ns/op 2331198 B/op 32513 allocs/op
BenchmarkSamplesJSONUnmarshal/series=100/dp=100/type=floats-14 255 4703817 ns/op 2331199 B/op 32513 allocs/op
BenchmarkSamplesJSONUnmarshal/series=100/dp=100/type=floats-14 253 4717326 ns/op 2331197 B/op 32513 allocs/op
BenchmarkSamplesJSONUnmarshal/series=100/dp=100/type=floats-14 254 4709905 ns/op 2331199 B/op 32513 allocs/op
BenchmarkSamplesJSONUnmarshal/series=100/dp=100/type=floats-14 254 4720884 ns/op 2331198 B/op 32513 allocs/op
BenchmarkSamplesJSONUnmarshal/series=100/dp=100/type=histograms-14 15 76232786 ns/op 21736113 B/op 432614 allocs/op
BenchmarkSamplesJSONUnmarshal/series=100/dp=100/type=histograms-14 15 75978942 ns/op 21736112 B/op 432614 allocs/op
BenchmarkSamplesJSONUnmarshal/series=100/dp=100/type=histograms-14 15 75836069 ns/op 21736096 B/op 432614 allocs/op
BenchmarkSamplesJSONUnmarshal/series=100/dp=100/type=histograms-14 15 75831358 ns/op 21736120 B/op 432614 allocs/op
BenchmarkSamplesJSONUnmarshal/series=100/dp=100/type=histograms-14 15 75595017 ns/op 21736106 B/op 432614 allocs/op
BenchmarkSamplesJSONUnmarshal/series=100/dp=100/type=histograms-14 15 75289086 ns/op 21736108 B/op 432614 allocs/op
BenchmarkSamplesJSONUnmarshal/series=100/dp=1000/type=floats-14 24 47381948 ns/op 23524799 B/op 302913 allocs/op
BenchmarkSamplesJSONUnmarshal/series=100/dp=1000/type=floats-14 24 47636734 ns/op 23524798 B/op 302913 allocs/op
BenchmarkSamplesJSONUnmarshal/series=100/dp=1000/type=floats-14 24 47657785 ns/op 23524802 B/op 302913 allocs/op
BenchmarkSamplesJSONUnmarshal/series=100/dp=1000/type=floats-14 25 47631397 ns/op 23524800 B/op 302913 allocs/op
BenchmarkSamplesJSONUnmarshal/series=100/dp=1000/type=floats-14 25 47335457 ns/op 23524796 B/op 302913 allocs/op
BenchmarkSamplesJSONUnmarshal/series=100/dp=1000/type=floats-14 24 49292708 ns/op 23524798 B/op 302913 allocs/op
BenchmarkSamplesJSONUnmarshal/series=100/dp=1000/type=histograms-14 2 791805896 ns/op 215608104 B/op 4302914 allocs/op
BenchmarkSamplesJSONUnmarshal/series=100/dp=1000/type=histograms-14 2 806855562 ns/op 215608088 B/op 4302914 allocs/op
BenchmarkSamplesJSONUnmarshal/series=100/dp=1000/type=histograms-14 2 825912480 ns/op 215608144 B/op 4302914 allocs/op
BenchmarkSamplesJSONUnmarshal/series=100/dp=1000/type=histograms-14 1 1197585209 ns/op 215608224 B/op 4302915 allocs/op
BenchmarkSamplesJSONUnmarshal/series=100/dp=1000/type=histograms-14 2 852256750 ns/op 215608128 B/op 4302914 allocs/op
BenchmarkSamplesJSONUnmarshal/series=100/dp=1000/type=histograms-14 2 929518375 ns/op 215608184 B/op 4302914 allocs/op
BenchmarkSamplesJSONUnmarshal/series=1000/dp=10/type=floats-14 175 6651326 ns/op 3161764 B/op 52016 allocs/op
BenchmarkSamplesJSONUnmarshal/series=1000/dp=10/type=floats-14 181 6515437 ns/op 3161766 B/op 52016 allocs/op
BenchmarkSamplesJSONUnmarshal/series=1000/dp=10/type=floats-14 187 6379439 ns/op 3161761 B/op 52016 allocs/op
BenchmarkSamplesJSONUnmarshal/series=1000/dp=10/type=floats-14 159 7166182 ns/op 3161763 B/op 52016 allocs/op
BenchmarkSamplesJSONUnmarshal/series=1000/dp=10/type=floats-14 184 6441652 ns/op 3161762 B/op 52016 allocs/op
BenchmarkSamplesJSONUnmarshal/series=1000/dp=10/type=floats-14 187 6351032 ns/op 3161761 B/op 52016 allocs/op
BenchmarkSamplesJSONUnmarshal/series=1000/dp=10/type=histograms-14 14 81279884 ns/op 22585861 B/op 453017 allocs/op
BenchmarkSamplesJSONUnmarshal/series=1000/dp=10/type=histograms-14 14 81719973 ns/op 22585897 B/op 453017 allocs/op
BenchmarkSamplesJSONUnmarshal/series=1000/dp=10/type=histograms-14 14 82418122 ns/op 22585890 B/op 453017 allocs/op
BenchmarkSamplesJSONUnmarshal/series=1000/dp=10/type=histograms-14 14 82229027 ns/op 22585868 B/op 453017 allocs/op
BenchmarkSamplesJSONUnmarshal/series=1000/dp=10/type=histograms-14 14 82217155 ns/op 22585904 B/op 453017 allocs/op
BenchmarkSamplesJSONUnmarshal/series=1000/dp=10/type=histograms-14 14 80724744 ns/op 22585860 B/op 453017 allocs/op
BenchmarkSamplesJSONUnmarshal/series=1000/dp=100/type=floats-14 22 51172394 ns/op 23305758 B/op 325016 allocs/op
BenchmarkSamplesJSONUnmarshal/series=1000/dp=100/type=floats-14 22 50912684 ns/op 23305757 B/op 325016 allocs/op
BenchmarkSamplesJSONUnmarshal/series=1000/dp=100/type=floats-14 22 50855328 ns/op 23305757 B/op 325016 allocs/op
BenchmarkSamplesJSONUnmarshal/series=1000/dp=100/type=floats-14 22 51150388 ns/op 23305757 B/op 325016 allocs/op
BenchmarkSamplesJSONUnmarshal/series=1000/dp=100/type=floats-14 22 52087830 ns/op 23305759 B/op 325016 allocs/op
BenchmarkSamplesJSONUnmarshal/series=1000/dp=100/type=floats-14 22 51490324 ns/op 23305759 B/op 325016 allocs/op
BenchmarkSamplesJSONUnmarshal/series=1000/dp=100/type=histograms-14 2 803180354 ns/op 217353872 B/op 4326017 allocs/op
BenchmarkSamplesJSONUnmarshal/series=1000/dp=100/type=histograms-14 2 805756958 ns/op 217353920 B/op 4326017 allocs/op
BenchmarkSamplesJSONUnmarshal/series=1000/dp=100/type=histograms-14 2 807653812 ns/op 217353864 B/op 4326017 allocs/op
BenchmarkSamplesJSONUnmarshal/series=1000/dp=100/type=histograms-14 2 800239896 ns/op 217353888 B/op 4326017 allocs/op
BenchmarkSamplesJSONUnmarshal/series=1000/dp=100/type=histograms-14 2 802372166 ns/op 217353856 B/op 4326017 allocs/op
BenchmarkSamplesJSONUnmarshal/series=1000/dp=100/type=histograms-14 2 808134729 ns/op 217353848 B/op 4326017 allocs/op
BenchmarkSamplesJSONUnmarshal/series=1000/dp=1000/type=floats-14 3 486888042 ns/op 235241754 B/op 3029016 allocs/op
BenchmarkSamplesJSONUnmarshal/series=1000/dp=1000/type=floats-14 3 486258528 ns/op 235241754 B/op 3029016 allocs/op
BenchmarkSamplesJSONUnmarshal/series=1000/dp=1000/type=floats-14 3 479984722 ns/op 235241754 B/op 3029016 allocs/op
BenchmarkSamplesJSONUnmarshal/series=1000/dp=1000/type=floats-14 3 475854042 ns/op 235241754 B/op 3029016 allocs/op
BenchmarkSamplesJSONUnmarshal/series=1000/dp=1000/type=floats-14 3 477163722 ns/op 235241760 B/op 3029016 allocs/op
BenchmarkSamplesJSONUnmarshal/series=1000/dp=1000/type=floats-14 3 476178917 ns/op 235241760 B/op 3029016 allocs/op
BenchmarkSamplesJSONUnmarshal/series=1000/dp=1000/type=histograms-14 1 7871798875 ns/op 2156073872 B/op 43029017 allocs/op
BenchmarkSamplesJSONUnmarshal/series=1000/dp=1000/type=histograms-14 1 7987310459 ns/op 2156073888 B/op 43029018 allocs/op
BenchmarkSamplesJSONUnmarshal/series=1000/dp=1000/type=histograms-14 1 7904908958 ns/op 2156073872 B/op 43029017 allocs/op
BenchmarkSamplesJSONUnmarshal/series=1000/dp=1000/type=histograms-14 1 7849830042 ns/op 2156073888 B/op 43029018 allocs/op
BenchmarkSamplesJSONUnmarshal/series=1000/dp=1000/type=histograms-14 1 7808607792 ns/op 2156073856 B/op 43029017 allocs/op
BenchmarkSamplesJSONUnmarshal/series=1000/dp=1000/type=histograms-14 1 7833902875 ns/op 2156073904 B/op 43029017 allocs/op
PASS
ok github.com/prometheus/common/model 186.364s
Loading
Loading