Conversation
Signed-off-by: David Ashpole <dashpole@google.com>
dashpole
force-pushed
the
om2_doc_comments
branch
from
September 18, 2026 20:57
c39ac90 to
718306c
Compare
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
Documentation-only changes are fully reviewed with no unresolved issues.
Pull request overview
Updates OpenMetrics 2.0 documentation to accurately describe supported metric types and unsupported types unavailable in client_model.
Changes:
- Documents support for all six
client_modelmetric types. - Clarifies that
infoandstatesetare unsupported. - Removes outdated work-in-progress wording.
File summaries
| File | Description |
|---|---|
expfmt/openmetrics_2_0_create.go |
Updates encoder documentation. |
expfmt/expfmt.go |
Updates format and API comments. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
dashpole
marked this pull request as ready for review
September 18, 2026 23:19
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #893
Update the documentation comments on
NewOpenMetricsFormatandMetricFamilyToOpenMetrics20to reflect that alldto.MetricTypemetric types (counter,gauge,summary,untyped,histogram, andgaugehistogram) are now implemented in the OpenMetrics 2.0 encoder (withinfoandstatesetunsupported as they are not present inclient_model).