chore: rename module to @prometheus/client_js#751
Conversation
|
I know that @krajorama mentioned Reality check: Go is of course an outlier since it imports directly from domain's namespace. And in Go packages with
|
|
I don't have a strong opinion, I feel that @prometheus-io/client_js would be nice to reflect the name of the repo it comes from, but I'm ok with @prometheus-io/client as well. (Note : currently Prometheus publishes packages under prometheus-io). @jdmarshall any preference? UPDATE: as far as I see I can freely add @prometheus organization, so we can do @prometheus prefix as well. |
|
Personally, I think |
| 'prom-client@latest': 'prom-client@latest', | ||
| 'prom-client@trunk': 'git@github.com:siimon/prom-client', | ||
| 'prom-client@current': { location: process.cwd() }, | ||
| '@prometheus-io/client@latest': '@prometheus-io/client@latest', |
There was a problem hiding this comment.
These are going to conflict with another PR that simplifies the names for the benchmarks. I'm landing that momentarily.
There was a problem hiding this comment.
Thanks for the heads up. I can rebase after the other PR lands.
There was a problem hiding this comment.
Also the line mentioned above is currently failing the benchmarks. You'll need to revert this line for now.
|
With no other knowledge I'd prefer @prometheus but I'd like to know what's already published under prometheus-io Hmm. The only thing that suggests prometheus-io as a better option is https://www.prometheus.io which I suppose is perhaps enough. |
|
Is there anything I can do to help move this forward? |
|
@cjihrig Yeah let's go with @prometheus instead of @promethius-io since Github seems like a more common destination from npmjs.com. And you need to revert the @latest change since there's a chicken and egg problem with updating the docs and then publishing the code. I was hoping @SimenB would approve the other change and you could build yours on top but at this point it's more expedient for me to rebase on top of yours instead, since mine is about 12 lines of code. |
|
I've made the requested changes. |
This commit updates the project name from prom-client to @prometheus/client_js to reflect the recent move. Signed-off-by: cjihrig <cjihrig@gmail.com>
Signed-off-by: cjihrig <cjihrig@gmail.com>
Signed-off-by: cjihrig <cjihrig@gmail.com>
Signed-off-by: cjihrig <cjihrig@gmail.com>
Signed-off-by: cjihrig <cjihrig@gmail.com>
This commit updates the project name from prom-client to @prometheus/client_js to reflect the recent move.
This is my first time contributing to this project under any package name, so please let me know if anything here is incorrect.