Skip to content

chore: rename module to @prometheus/client_js#751

Merged
jdmarshall merged 5 commits into
prometheus:mainfrom
cjihrig:project-rename
Jul 1, 2026
Merged

chore: rename module to @prometheus/client_js#751
jdmarshall merged 5 commits into
prometheus:mainfrom
cjihrig:project-rename

Conversation

@cjihrig

@cjihrig cjihrig commented Jun 25, 2026

Copy link
Copy Markdown
Contributor

This commit updates the project name from prom-client to @prometheus/client_js to reflect the recent move.

This is my first time contributing to this project under any package name, so please let me know if anything here is incorrect.

@slagiewka

Copy link
Copy Markdown

I know that @krajorama mentioned client_js as the desired state in #750 (comment). But this might've been intended to point to the repository name, not package name.

Reality check:
Python: pip install prometheus-client
Ruby: gem install prometheus-client
Rust: cargo add prometheus-client

Go is of course an outlier since it imports directly from domain's namespace. And in Go packages with _ in name are more commonplace.

prometheus-client is taken on npm. @prometheus/client would be more aligned with the npm ecosystem.

@krajorama krajorama requested a review from jdmarshall June 25, 2026 10:50
@krajorama

krajorama commented Jun 25, 2026

Copy link
Copy Markdown
Member

I don't have a strong opinion, I feel that @prometheus-io/client_js would be nice to reflect the name of the repo it comes from, but I'm ok with @prometheus-io/client as well. (Note : currently Prometheus publishes packages under prometheus-io).

@jdmarshall any preference?

UPDATE: as far as I see I can freely add @prometheus organization, so we can do @prometheus prefix as well.

@cjihrig

cjihrig commented Jun 25, 2026

Copy link
Copy Markdown
Contributor Author

Personally, I think @prometheus/client would be the nicest and clearest, since that is what people will be typing when they install. However, if @prometheus-io is already being used, then I think @prometheus-io/client would be the best option to avoid confusion and managing multiple package scopes. The _js probably isn't needed since the package is coming from npm.

Comment thread benchmarks/index.js Outdated
'prom-client@latest': 'prom-client@latest',
'prom-client@trunk': 'git@github.com:siimon/prom-client',
'prom-client@current': { location: process.cwd() },
'@prometheus-io/client@latest': '@prometheus-io/client@latest',

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are going to conflict with another PR that simplifies the names for the benchmarks. I'm landing that momentarily.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the heads up. I can rebase after the other PR lands.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also the line mentioned above is currently failing the benchmarks. You'll need to revert this line for now.

@jdmarshall

jdmarshall commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

With no other knowledge I'd prefer @prometheus but I'd like to know what's already published under prometheus-io

Hmm. The only thing that suggests prometheus-io as a better option is https://www.prometheus.io which I suppose is perhaps enough.

@cjihrig

cjihrig commented Jun 30, 2026

Copy link
Copy Markdown
Contributor Author

Is there anything I can do to help move this forward?

@jdmarshall

jdmarshall commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

@cjihrig Yeah let's go with @prometheus instead of @promethius-io since Github seems like a more common destination from npmjs.com.

And you need to revert the @latest change since there's a chicken and egg problem with updating the docs and then publishing the code.

I was hoping @SimenB would approve the other change and you could build yours on top but at this point it's more expedient for me to rebase on top of yours instead, since mine is about 12 lines of code.

@cjihrig

cjihrig commented Jul 1, 2026

Copy link
Copy Markdown
Contributor Author

I've made the requested changes.

cjihrig added 5 commits June 30, 2026 22:53
This commit updates the project name from prom-client to
@prometheus/client_js to reflect the recent move.

Signed-off-by: cjihrig <cjihrig@gmail.com>
Signed-off-by: cjihrig <cjihrig@gmail.com>
Signed-off-by: cjihrig <cjihrig@gmail.com>
Signed-off-by: cjihrig <cjihrig@gmail.com>
Signed-off-by: cjihrig <cjihrig@gmail.com>
@jdmarshall jdmarshall merged commit 5273752 into prometheus:main Jul 1, 2026
14 checks passed
@cjihrig cjihrig deleted the project-rename branch July 1, 2026 03:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants