refactor(webex): move configuration types into webex package

[TheMeier]

Pull Request Checklist

• I have signed-off my commits
• I will follow best practices for contributing to this project

Which user-facing changes does this PR introduce?

NONE

contains #5572 #5573 #5574

[coderabbitai]

Understand this PR’s impact

Explore downstream dependencies and potential security impact with Blast Radius.

View blast radius →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository: prometheus/alertmanager/.coderabbit.yaml

Review profile: CHILL

Plan: Advanced

Run ID: fd8b2102-61a2-4025-8596-b611b6c3c797

📥 Commits

Reviewing files that changed from the base of the PR and between d8ce6f1 and 1de992d.

📒 Files selected for processing (4)

• config/config.go
• config/notifiers.go
• config/notifiers_test.go
• notify/webex/webex_test.go

💤 Files with no reviewable changes (2)

• config/notifiers_test.go
• config/notifiers.go

Included review availability: Your plan provides up to 8 included reviews per hour; 7 remain after this review.

---

📝 Walkthrough

Walkthrough

Webex configuration now resides in notify/webex. The notifier, receiver configuration, and tests use the package-local WebexConfig type. The former configuration-package type, defaults, validation, and test were removed.

Changes

Webex configuration migration

Layer / File(s)	Summary
Webex configuration contract notify/webex/config.go, notify/webex/config_test.go, config/notifiers.go, config/notifiers_test.go	The WebexConfig type, default configuration, YAML unmarshalling, validation, and tests moved to notify/webex. The former declarations and test were removed from config.
Webex notifier type updates notify/webex/webex.go, notify/webex/webex_test.go	The notifier constructor, stored configuration, and tests now use the local WebexConfig type.
Receiver configuration wiring config/config.go	Receiver.WebexConfigs now uses webex.WebexConfig.

Priority: ⬇️ Low

Estimated code review effort: 3 (Moderate) | ~20 minutes

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (2 warnings)

Check name	Status	Explanation	Resolution
Description check	⚠️ Warning	The description includes sign-off, contribution compliance, release notes, and issue references, but it omits most required checklist items and does not clearly mark which items are not applicable.	Complete the required checklist. Add the issue references under the issue section, mark applicable bugfix, feature, performance, and breaking-change items, confirm documentation status, and confirm that the related configuration tests cover…
Docstring Coverage	⚠️ Warning	Docstring coverage is 11.11% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 36 functions across 18 files.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (3 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly and concisely describes the main change: moving Webex configuration types into the Webex package.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

Full details: Description check

Resolution

Complete the required checklist. Add the issue references under the issue section, mark applicable bugfix, feature, performance, and breaking-change items, confirm documentation status, and confirm that the related configuration tests cover the exported API change.

• Fix all pre-merge checks with AI

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create a new PR

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[SoloJacobs]

small nit

[SoloJacobs]

I think http_config.authorization is more correct.

[TheMeier]

fixed