[scanner] fix: propagate lima-e2e browser-verification failures - #160
Open
kubestellar-hive[bot] wants to merge 1 commit into
Open
kubestellar-hive[bot] wants to merge 1 commit into
kubestellar-hive[bot] wants to merge 1 commit into
Conversation
![sec-check[bot]](https://github.githubassets.com/images/gravatars/gravatar-user-420.png){kind=avatar}
tests/e2e/test_kubestellar_browser_login.py exits non-zero when the
console never becomes ready or the kiosk-gate assertion fails, but
scripts/lima-e2e-kubestellar-test.sh wrapped the call in an
'|| { echo ... }' fallback that swallowed any failure and always
printed 'Lima VM end-to-end verification passed!'. Remove the
fallback so the script (running under set -euo pipefail) propagates
the real exit code.
Fixes #159
Signed-off-by: sec-check[bot] <sec-check[bot]@users.noreply.github.com>
kubestellar-hive
Bot
added
hold
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix
tests/e2e/test_kubestellar_browser_login.pyexits non-zero (viasys.exit(1)on console-readiness timeout, or anAssertionErroron thekiosk-gate check) when the KubeStellar console browser verification fails.
scripts/lima-e2e-kubestellar-test.shwrapped that call in:which swallows any non-zero exit and lets the script fall through to
unconditionally print
\"Lima VM end-to-end verification passed!\"andexit 0. This job could never fail on a real regression in the console
login flow or kiosk gate.
This PR removes the
|| { ... }fallback so the script (already runningunder
set -euo pipefail) propagates the Python script's real exit code.Files changed:
scripts/lima-e2e-kubestellar-test.shFixes #159
Filed by scanner agent (ACMM L5 — hold-gated mode). Hold-gated: human review required.
— hive: agent=scanner backend=copilot