test(build-depends): lock os-countme curl+jq FSDK paths (#96) - #150
Closed
kylerankin wants to merge 2 commits into
Closed
kylerankin wants to merge 2 commits into
kylerankin wants to merge 2 commits into
Conversation
Regression test for projectbluefin#96. The curl dependency in elements/bluefin-server/os-countme.bst was inferred rather than verified; the minimal image ships neither curl nor jq, so a wrong freedesktop-sdk junction path fails to resolve and the image will not build. Confirmed that the pinned freedesktop-sdk ref (freedesktop-sdk-26.08.0, elements/freedesktop-sdk.bst) ships both elements/components/curl.bst and elements/components/jq.bst. FSDK's element-path: elements resolves the dependency string freedesktop-sdk.bst:components/curl.bst to that path, so the dependency must stay on it. Lock the paths in a unit test so a wrong path regressing os-countme.bst fails CI before the build does. Signed-off-by: kylerankin <kylerankin@users.noreply.github.com>
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolves #96 — Confirm the curl component path in the freedesktop-sdk junction.
Finding
The curl dependency in
elements/bluefin-server/os-countme.bstisfreedesktop-sdk.bst:components/curl.bst. This path is confirmed correct:project.confsetselement-path: elements, so the junctiondependency
components/curl.bstresolves toelements/components/curl.bst.freedesktop-sdk-26.08.0, seeelements/freedesktop-sdk.bst,commit
db97cce32...) ships bothelements/components/curl.bstandelements/components/jq.bst.(
components/ca-certificates.bst,components/jq.bst,components/systemd.bst, ...),and jq was already confirmed via projectbluefin/dakota.
So no change to
os-countme.bstis needed — the path resolves and the image builds.Change
Adds a unit test in
tests/unit/test_build_depends.pythat locks the exactcomponents/curl.bstandcomponents/jq.bstdependency paths onos-countme.bst. The minimal image ships neither curl nor jq, so a wrongjunction path would fail to resolve and break the build; this test fails CI
before the build does if those paths ever regress.
Runs in plain
pytest(no junction fetch required), so it guards the paths inthe unit-tests CI job.
— hive: backend=pi model=lemonade/Ornith-1.5-35B-A3B-GGUF-Q6_K
🐝 Hive Agent:
contributor| SHA:5643b2b