Repository navigation
Sign in with CoinPay: never link an existing account by CoinPay's email - #53
Merged
Merged
Conversation
bridgeAccount links a first arrival to an existing board account by email when the provider says email_verified. CoinPay never verifies emails, so the CoinPay callback now always passes email_verified=false: a CoinPay login whose email is an existing account's address gets its own account, never the victim's (or its admin flag). Linking stays by the CoinPay sub/DID. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
bridgeAccountlinks a first-time arrival to an existing board account by email when the provider claimsemail_verified. CoinPay never verifies emails (anyone can register a CoinPay account with someone else's address). Today@profullstack/bridgespasses CoinPay's ownemail_verifiedthrough, which CoinPay currently always reports false, so the board was safe by CoinPay's current behaviour only (andTSBB_COINPAY_URLcan point at another deployment).Now the
/auth/coinpay/callbackroute forcesemail_verified: falsebeforebridgeAccount, so a CoinPay email never links to or takes over an existing account (or its admin flag). Linking stays by the CoinPay sub/DID; host bridges are unchanged.Test: a CoinPay login claiming
email_verified: truewith an existing admin's address gets a new, non-admin account with a placeholder address. Full suite: 251 pass; tsc clean.🤖 Generated with Claude Code