Repository navigation
Do not fail a release because Chocolatey is still moderating - #122
Merged
Merged
Conversation
v3.16.0's release went red on a Chocolatey 403. The same API key had pushed 3.15.1 an hour earlier, so it is not the credential: tronbrowser is a brand-new package whose first submission is still with their moderators, and Chocolatey will not queue a second unapproved version behind it. That is a state to wait out, and until a human gets to it every release run goes red on a job that is behaving exactly as designed. Swallowing a 403 outright would be the wrong fix, and the same mistake that let this pipeline spend three months publishing nothing while reporting success. So the two cases are told apart rather than merged. Chocolatey's public feed lists approved versions only. No approved version means the package has never cleared moderation, so a refusal is the moderation gate and the run continues with an explanation. A package that IS listed and still refuses is a wrong key or someone else owning the id, and that still fails loudly. Checked against the live feed both ways before trusting it: tronbrowser returns zero approved versions, while 7zip returns 40, vlc 40 and our own pairux 17. A parser that always returned empty would have silently swallowed every 403, which is precisely the failure being avoided, so proving the positive case mattered more than proving the negative one.
Contributor
ThreatCrush Security Scan52 finding(s) HIGH/CRITICAL: 3 | MEDIUM: 28 | LOW: 21
…and 2 more. Full results in the Security tab. Snippets are redacted; ThreatCrush never prints matched credential material. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
v3.16.0's release went red on a Chocolatey
403 Forbidden.The same API key pushed 3.15.1 an hour earlier, so it isn't the credential:
tronbrowseris a brand-new package whose first submission is still with their moderators, and Chocolatey won't queue a second unapproved version behind it. That's a state to wait out — but until a human moderator gets to it, every release run goes red on a job behaving exactly as designed.Not by swallowing the 403
Blanket-swallowing it would be the same mistake that let this pipeline spend three months publishing nothing while reporting success. The two cases are told apart instead:
Verified against the live feed, both directions
tronbrowser7zipvlcpairux(ours)Proving the positive case mattered more than the negative one: a parser that always returned empty would have silently swallowed every 403, which is precisely the failure being avoided.
🤖 Generated with Claude Code