Repository navigation
feat: Sign in with CoinPay - #262
Merged
Merged
Conversation
CoinPay is the fleet's master account. Adds "Sign in with CoinPay" as the first panel on /login and /signup and a CoinPay section on /account (Connect / Disconnect, add an email), via @profullstack/coinpay-onboard 0.3.1: auth code + PKCE S256 + state + nonce, client secret on the exchange, id_token iss/aud/exp/nonce and userinfo sub checks. - Bound by the CoinPay sub (coinpay_identities), never by email. A CoinPay email that matches an existing account gets its own new account on a coinpay.invalid placeholder; the CoinPay email is contact info only. - State is pinned to the browser by an httpOnly cookie and spent from a server-side coinpay_pending row (single use, 10 minutes). - Connect needs a session and the same session must finish the callback. - Disconnect is refused when CoinPay is the only way in; a placeholder account's last passkey is kept once CoinPay is gone. - A CoinPay-only account adds a real address by a mailed sign-in link (login_tokens.claim_user_id); a taken address is refused. - Placeholder accounts are off the digest and cannot add email alerts. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CoinPay is the fleet's master account: this adds Sign in with CoinPay to rssamplifier.com.
@profullstack/coinpay-onboard0.3.1): auth code + PKCE S256 + state + nonce, exact redirecthttps://rssamplifier.com/api/v1/coinpay/oauth/callback, client secret on the code exchange, id_token iss/aud/exp/nonce check, userinfo sub match. State is pinned to the browser by an httpOnly cookie and kept server-side as a single-usecoinpay_pendingrow.sub(coinpay_identities). A CoinPay email that matches an existing account never signs into it; a new account gets acoinpay.invalidplaceholder and the CoinPay email is stored on the identity row as contact info only. Connect needs a signed-in session and the same session must finish the callback.login_tokens.claim_user_id); a taken address is refused. Until then they are off the weekly digest and cannot add email alerts (webhooks/push still work).20261029060855_coinpay_identities.sql: two new tables + one nullable column onlogin_tokens; applied by the poller on boot.Tests:
packages/auth/test/coinpay.test.js(email collision, link needs the same session, forged/missing/replayed state, safe next, disconnect guard, claim link). Full suite green locally against Postgres 17 (db 348, web 519, auth 30, ...).🤖 Generated with Claude Code