Repository navigation
Bump @profullstack/contact-form to 0.3.0; /sales rebuilds errors from codes - #259
Merged
Merged
Conversation
… codes 0.3.0 sends a plain form post back with ?error=<code>&field=&reason=, never text, so the formErrors() allowlist (which matched message text) would show nothing. The page now asks salesContact.errorMessage(searchParams), which rebuilds the form's own message; a crafted ?error= gets the generic line. - use_case: minLength 10 instead of the pattern workaround, checked in the browser too. - An unexpected failure answers "That did not send. Try again, or email hello@rssamplifier.com." instead of the bare error. Version 0.2.2. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pins
@profullstack/contact-form0.3.0 (from 0.2.0)./salesshowssalesContact.errorMessage(searchParams);formErrors()and the old code switch are gone (0.3.0 redirects with codes, never text).use_case:minLength: 10replaces the pattern; JSON message is now "What do you want the corpus for? is too short (10 characters at least)".responses.errorsays the old "That did not send..." line instead of the raw error.Known limit: the DB-backed 3/hour check runs in
verify, so on a no-JS post it comes back as?error=invalidwith no field and reads "Invalid submission." (the in-memory 3/hour guard limit still reads the old "several enquiries" line).🤖 Generated with Claude Code