Repository navigation
fix: PATCH /jobs/:slug saves applySchema - #332
Merged
Merged
Conversation
The route validated a sent applySchema and then dropped it: patchJob had no apply_schema write and the field was missing from JOB_PATCH_FIELDS. Also write it in editJob so both edit paths agree. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PATCH accepted
applySchema, ran it through the normaliser, then never wrote it:patchJobhad noapply_schemaassignment andapplySchemawas missing fromJOB_PATCH_FIELDS. Now a sentapplySchemais written (only when sent, so partial patches still leave it alone;nullresets to the default).editJobwrites it too.Tests: unit test in job-patch-fields, API test that PATCHes a new schema and reads it back. Full suite 1035/1035 against a real Postgres.
🤖 Generated with Claude Code